compat: use a CurrentRef waker in 01 compat #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to poll a `Future01`, it isn't yet necessary to call `task01::current()`, nor store it in an `Arc::new`. All that is needed is a "reference", and if someone calls `waker().clone()`, *then* we can do the allocations.
|
CI failure seems unrelated to this PR. |
|
CI is definitely unrelated, doc failure is the buggy rustdoc link detection (which I will open a pr to disable soon) and benchmarks are caused by rust-lang/rust#54116, left a comment there to try and sort that out. |
|
I've tried restarting those CI jobs, but they still fail. Seems this can't be merged with them failing... |
|
Admins can merge even with failing ci (and as far as I know only the admins have merge rights here anyway). |
|
Merged, sorry for the delay (and feel free to ping if things are getting stuck.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to poll a
Future01, it isn't yet necessary to calltask01::current(), nor store it in anArc::new. All that is neededis a "reference", and if someone calls
waker().clone(), then we cando the allocations.