Add HashSet#raw_table #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddunbar
force-pushed
the
set-raw-table
branch
from
76dddaa to
e233127
Compare
Just like rust-lang#335 did for `HashMap`, I'd like to add access to the underlying `RawTable` for `HashSet`. I intend to use it in conjunction with rust-lang#354 to pull random elements from a `HashSet`.
braddunbar
force-pushed
the
set-raw-table
branch
from
e233127 to
ed9a3d5
Compare
Amanieu
reviewed
Sep 8, 2022
src/set.rs
Outdated
| /// | ||
| /// # Note | ||
| /// | ||
| /// Calling the function safe, but using raw hash table API's may require |
Member
There was a problem hiding this comment.
Suggested change
| /// Calling the function safe, but using raw hash table API's may require | |
| /// Calling the function is safe, but using raw hash table API's may require |
This should probably be fixed in the HashMap version as well.
Contributor
Author
There was a problem hiding this comment.
Fixed both places in 6041b5a, along with a little tweaking of the grammar in that sentence. Let me know if you'd like something different!
Member
|
@bors r+ Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like #335 did for
HashMap, I'd like to add access to the underlyingRawTableforHashSet. I intend to use it in conjunction with #354 to pull random elements from aHashSet.Let me know if I've missed something here or you'd like things implemented differently. I'll be happy to change it up!