Skip to content

Conversation

@zakarumych
Copy link
Contributor

New version fixes some inconsistencies with std

@zakarumych
Copy link
Contributor Author

Build error in bumpalo encountered by CI is fixed in fitzgen/bumpalo#299

@cuviper
Copy link
Member

cuviper commented Dec 11, 2025

Just to be explicit, this is definitely a breaking change -- as the bumpalo failure demonstrates.

@zakarumych
Copy link
Contributor Author

zakarumych commented Dec 11, 2025

Bumpalo fails without this change as well.

@zakarumych
Copy link
Contributor Author

But it is a breaking change for users who use allocator-api2 for hashbrown types, as they would need to upgrade their version.

The minor version update is forced by new implementation Allocator for &mut A, that was added to core.

@cuviper
Copy link
Member

cuviper commented Dec 11, 2025

But it is a breaking change for users who use allocator-api2 for hashbrown types, as they would need to upgrade their version.

That's really what I meant, as it's (implicitly) a public dependency. And this is fine for hashbrown to change IMO, as long as we do bump semver for it.

I admit I didn't look at what actually went wrong with bumpalo in particular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants