ctest: Add extraction of relevant types. #4485

mbyx · 2025-06-13T08:04:45Z

Adds support for extracting relevant types (such as Structs, Unions, Aliases, etc.) from Rust code.

mbyx · 2025-06-13T08:06:37Z

Would it be a good idea to add tests at this point for extraction as well? By just counting up how many aliases, structs, unions etc. FfiItems could find in the test inputs and if it matches previous runs.

ctest-next/src/ffi_items.rs

ctest-next/src/ast/field.rs

ctest-next/src/ffi_items.rs

ctest-next/src/ast/constant.rs

ctest-next/src/ast/item.rs

tgross35 · 2025-06-16T00:41:12Z

Would it be a good idea to add tests at this point for extraction as well? By just counting up how many aliases, structs, unions etc. FfiItems could find in the test inputs and if it matches previous runs.

A test wouldn't be bad. I would just make a single tests.rs unit test file and provide an input string of Rust code that includes one of each item, parse that to syn::parse_file, get it to a FfiItems instance, and assert that the items you expect are in there (just checking the ident is fine).

ctest-next/src/ast/constant.rs

ctest-next/src/ffi_items.rs

ctest-next/src/lib.rs

ctest-next/src/ffi_items.rs

ctest-next/src/lib.rs

ctest-next/tests/extraction.rs

ctest-next/tests/input/all_items.rs

ctest-next/src/ast/mod.rs

mbyx · 2025-06-16T18:00:57Z

There seems to be some kind of bug with #[expect(unused)] when used with unit tests. When I keep it on a method that is only used in a unit test, it says that the method is actually in use so the lint isn't being upheld. But when I remove the #[expect(unused)] it says that the method is not in use.

tgross35 · 2025-06-16T18:05:33Z

That's not a bug - the type is indeed used when cfg(test) is set, and unused otherwise. So they need to be cfg_attr(not(test), expect(unused)).

tgross35 · 2025-06-16T18:08:06Z

ctest-next/src/ffi_items.rs

+}
+
+#[cfg(test)]
+mod tests {


Could you put the tests in a separate tests.rs file? And then move the all_items.rs contents to a const ALL_ITEMS: &str = r#"..."#; in tests.rs so it doesn't need to be a standalone file. You can just skip the expand step.

This is the last fix then please squash and LGTM!

tgross35 · 2025-06-16T18:13:35Z

You will need to rebase as well to fix some of the CI here

tgross35 · 2025-06-16T18:19:43Z

Thank you!

rustbot added ctest Issues relating to the ctest crate S-waiting-on-review labels Jun 13, 2025

tgross35 changed the title ~~Add extraction of relevant types.~~ ctest: Add extraction of relevant types. Jun 15, 2025