Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Port newlib hypotf #240

Closed

Conversation

ChiefMilesEdgeworth
Copy link

Closes #137

  • Ports the newlib version of hypotf into the main module
  • Moves the old code into a submodule musl
  • Adds tests for hypotf

@ChiefMilesEdgeworth
Copy link
Author

Actually, this has a test error on the cargo test --features musl-reference-tests test.
This has to do with the new directory added, and I'm not sure what I could do to fix that. I'll dig around, but if someone knows where the issue is I'll accept the help

@ChiefMilesEdgeworth
Copy link
Author

The test still fails, but now it's a docker issue, so I have no idea.

@ChiefMilesEdgeworth
Copy link
Author

Here's the error:

error[E0463]: can't find crate for `std`
  |
  = note: the `x86_64-unknown-linux-musl` target may not be installed

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
thread 'main' panicked at 'assertion failed: status.success()', build.rs:344:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@alexcrichton
Copy link
Member

Thanks! If we switch the implementations then there's no need to keep the old implementation. Is this implementation better than the old one? (e.g. faster, more accurate, etc)

@ChiefMilesEdgeworth
Copy link
Author

The reason for porting this implementation as I understand it was to avoid using f64s. I'm not sure how to benchmark the speed differences, but the theory is that this will run significantly faster on architectures without a builtin representation for f64 types. I think most of the discussion on this was in the issue this PR closes, #137

@tgross35
Copy link
Contributor

Sorry this PR has been around so long. I think that similar to #169 there may be some licensing concerns here, but we might have an alternative solution.

This crate has also since been merged into the https://github.com/rust-lang/compiler-builtins repo, so I am going to close this.

@tgross35 tgross35 closed this Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port newlib's hypotf
3 participants