Add canonical-site-url setting
#2706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
roberth
force-pushed
the
canonical-site-url
branch
from
e421180 to
9c26fc4
Compare
This comment has been minimized.
This comment has been minimized.
roberth
force-pushed
the
canonical-site-url
branch
from
9c26fc4 to
cbca16c
Compare
roberth
force-pushed
the
canonical-site-url
branch
from
cbca16c to
fe29dc1
Compare
This comment has been minimized.
This comment has been minimized.
pinage404
approved these changes
Sep 14, 2025
|
I'd really like to have this functionality; is there a way I can help advance this PR? I want it for #1238. |
Based on the conversation in rust-lang#1238, this implements the suggestion by markhildreth to implement such a setting. I've additionally infixed `-site-` to highlight the relationship with the `site-url`, and to distinguish it from the canonical URL as it occurs in a page.
roberth
force-pushed
the
canonical-site-url
branch
from
fe29dc1 to
2554834
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
I've rebased and put my suggestion for a changelog entry in the PR description, because it kept causing conflicts. Let us know if there's anything else we can do! |
|
☔ The latest upstream changes (possibly #2905) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
This implements the suggestion by markhildreth to implement such a setting, based on the conversation in #1238.
<link rel="canonical">plays an important role in avoiding an SEO penalty when users deploy multiple versions of their site.I've additionally infixed
-site-to highlight the relationship with thesite-url, and to distinguish it from the canonical URL as it occurs in a page.This is a more user-friendly alternative to #2415 as it's an "end to end" solution with documentation. (It may have usages beyond this use case though)
Let me know if there's anything I should improve.
When this is done, I'd like to implement a setting for opting in to clean URLs without the
.htmlsuffix so that we can close the whole issue.Changelog suggestion (not included due to repeated conflicts...)