libc-misc test freebsd fixes attempt #3177
Conversation
devnexen
force-pushed
the
fix_pthread_misc_fbsd
branch
4 times, most recently
from
9867993 to
15bf480
Compare
devnexen
force-pushed
the
fix_pthread_misc_fbsd
branch
2 times, most recently
from
fd01ea5 to
e47c669
Compare
devnexen
force-pushed
the
fix_pthread_misc_fbsd
branch
3 times, most recently
from
ac7b2f5 to
bf66c21
Compare
|
@rustbot review |
| let result = this.ftruncate64(fd, length)?; | ||
| this.write_scalar(result, dest)?; | ||
| } | ||
| "ftruncate" => { |
There was a problem hiding this comment.
If you're adding this for all targets now we should probably have a test for it... libc-fs.rs sound like the right file.
We've historically been pretty bad with libc tests for our FS APIs though. And test_posix_mkstemp should probably be in libc-fs.rs as well. So if you prefer we can open an issue to track fixing this in the future.
There was a problem hiding this comment.
There's still no test for this function, is there?
There was a problem hiding this comment.
I did not add purposely, can be done separately.
There was a problem hiding this comment.
I said it should either be done here or have an issue to track it. :)
I created an issue: #3179
devnexen
force-pushed
the
fix_pthread_misc_fbsd
branch
6 times, most recently
from
1df561d to
553db9a
Compare
|
@rustbot review |
| @@ -1,4 +1,5 @@ | |||
| //@ignore-target-windows: no libc on Windows | |||
| //@ignore-target-freebsd | |||
There was a problem hiding this comment.
| //@ignore-target-freebsd | |
| //@ignore-target-freebsd: FIXME needs foreign function `stat@FBSD_1.0` |
There was a problem hiding this comment.
Note could be fixed in "all fs" next PR eventually.
devnexen
force-pushed
the
fix_pthread_misc_fbsd
branch
2 times, most recently
from
cf2a07f to
ea353db
Compare
devnexen
force-pushed
the
fix_pthread_misc_fbsd
branch
from
ea353db to
2472e70
Compare
|
Looks good, thanks! |
|
☀️ Test successful - checks-actions |
No description provided.