-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libc direct test for shims and update CONTRIBUTING.md #3398
Conversation
May I know how to generate the error presented in CI locally? I tested with the command below and no error is shown.
|
You have to check which target the tests are failing for. If you scroll up from the test failure you will see
So the target is |
@RalfJung |
LGTM, thanks! |
Sorry for doing force push, this is my first time using squash, so I am not sure why the push is rejected after squashing. Thank you for your guidance and multiple rounds of reviews for this PR, I really learned a lot! I will work on implementing some easier shim next. |
Force-pushing is expected after squashing. :) This looks right, thanks for the PR! |
☀️ Test successful - checks-actions |
Add more
libc
direct test for shims as mentioned in #3179.Changes:
libc
direct tests forrename
andftruncate64
pass-dep
test inCONTRIBUTING.md