Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libc direct test for shims and update CONTRIBUTING.md #3398

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

tiif
Copy link
Contributor

@tiif tiif commented Mar 23, 2024

Add more libc direct test for shims as mentioned in #3179.

Changes:

  • Added libc direct tests for rename and ftruncate64
  • Added the command for running pass-dep test in CONTRIBUTING.md

@tiif tiif marked this pull request as draft March 23, 2024 15:06
@tiif tiif marked this pull request as ready for review March 23, 2024 15:24
@tiif
Copy link
Contributor Author

tiif commented Mar 23, 2024

May I know how to generate the error presented in CI locally? I tested with the command below and no error is shown.

./miri run --dep ./tests/pass-dep/shims/libc-fs.rs -Zmiri-disable-isolation --target x86_64-apple-darwin
./miri run --dep ./tests/pass-dep/shims/libc-fs.rs -Zmiri-disable-isolation --target x86_64-unknown-linux-gnu

@RalfJung
Copy link
Member

RalfJung commented Mar 23, 2024

May I know how to generate the error presented in CI locally?

You have to check which target the tests are failing for. If you scroll up from the test failure you will see

## Running ui tests in tests/pass-dep against miri for i686-unknown-linux-gnu

So the target is i686-unknown-linux-gnu.

@tiif
Copy link
Contributor Author

tiif commented Mar 24, 2024

@RalfJung
Ok, the CI is finally green. Please take a look whenever you find it convenient, thanks!

@RalfJung
Copy link
Member

LGTM, thanks!
Please squash the commits.

@tiif tiif force-pushed the add_libc_fs_test branch from ba2469c to 77a898b Compare March 24, 2024 14:06
@tiif
Copy link
Contributor Author

tiif commented Mar 24, 2024

Sorry for doing force push, this is my first time using squash, so I am not sure why the push is rejected after squashing. Thank you for your guidance and multiple rounds of reviews for this PR, I really learned a lot! I will work on implementing some easier shim next.

@RalfJung
Copy link
Member

Force-pushing is expected after squashing. :) This looks right, thanks for the PR!
@bors r+

@bors
Copy link
Contributor

bors commented Mar 24, 2024

📌 Commit 77a898b has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 24, 2024

⌛ Testing commit 77a898b with merge c8649a5...

@bors
Copy link
Contributor

bors commented Mar 24, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing c8649a5 to master...

@bors bors merged commit c8649a5 into rust-lang:master Mar 24, 2024
8 checks passed
@tiif tiif deleted the add_libc_fs_test branch November 5, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants