Skip to content

clippy fix: use div_ceil #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025
Merged

clippy fix: use div_ceil #468

merged 1 commit into from
Jul 5, 2025

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Jul 4, 2025

const FULL_BIT_MASK: Self::BitMask = {
const LEN: usize = ($lanes + 7) / 8;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, it didn't work in this scope?

Copy link
Member Author

@hkBst hkBst Jul 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it has the right scope to be used for BitMask, but looking at this code again, I'm wondering why I didn't reuse the LaneCount::BITMASK_LEN...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now done, seems much better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@calebzulawski calebzulawski merged commit 3439347 into rust-lang:master Jul 5, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants