automata: call Vec::shrink_to_fit in a few strategic places
#1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other parts of `regex-automata` do this implicitly by using `Box<[T]>`, btu it's not always straight-forward to use `Box<[T]>`. (Or, at least, non-annoying.) In some of those cases here, we call `Vec::shrink_to_fit` to decrease memory usage. These are probably the biggest offenders, but I didn't do a thorough investigation here. Fixes #1297
BurntSushi
force-pushed
the
ag/improve-memory-usage
branch
from
3e95ca6 to
4b3e434
Compare
|
Typo: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other parts of
regex-automatado this implicitly by usingBox<[T]>,btu it's not always straight-forward to use
Box<[T]>. (Or, at least,non-annoying.) In some of those cases here, we call
Vec::shrink_to_fitto decrease memory usage.
These are probably the biggest offenders, but I didn't do a thorough
investigation here.
Fixes #1297