Skip to content

feat: ide-assist, generate blanket trait impl #19771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,244 changes: 1,244 additions & 0 deletions crates/ide-assists/src/handlers/generate_blanket_trait_impl.rs

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions crates/ide-assists/src/lib.rs
Original file line number Diff line number Diff line change
@@ -152,6 +152,7 @@ mod handlers {
mod flip_comma;
mod flip_or_pattern;
mod flip_trait_bound;
mod generate_blanket_trait_impl;
mod generate_constant;
mod generate_default_from_enum_variant;
mod generate_default_from_new;
@@ -288,6 +289,7 @@ mod handlers {
generate_default_from_enum_variant::generate_default_from_enum_variant,
generate_default_from_new::generate_default_from_new,
generate_delegate_trait::generate_delegate_trait,
generate_blanket_trait_impl::generate_blanket_trait_impl,
generate_derive::generate_derive,
generate_documentation_template::generate_doc_example,
generate_documentation_template::generate_documentation_template,
40 changes: 40 additions & 0 deletions crates/ide-assists/src/tests/generated.rs
Original file line number Diff line number Diff line change
@@ -1270,6 +1270,46 @@ fn foo<T: Copy + Clone>() { }
)
}

#[test]
fn doctest_generate_blanket_trait_impl() {
check_doc_test(
"generate_blanket_trait_impl",
r#####"
trait $0Foo<T: Send>: ToOwned
where
Self::Owned: Default,
{
fn foo(&self) -> T;
fn print_foo(&self) {
println!("{}", self.foo());
}
}
"#####,
r#####"
trait Foo<T: Send>: ToOwned
where
Self::Owned: Default,
{
fn foo(&self) -> T;
fn print_foo(&self) {
println!("{}", self.foo());
}
}
$0impl<T: Send, This: ToOwned> Foo<T> for This
where
Self::Owned: Default,
{
fn foo(&self) -> T {
todo!()
}
}
"#####,
)
}

#[test]
fn doctest_generate_constant() {
check_doc_test(
19 changes: 13 additions & 6 deletions crates/ide-assists/src/utils.rs
Original file line number Diff line number Diff line change
@@ -747,16 +747,23 @@ fn generate_impl_inner(
.clone_for_update();

// Copy any cfg attrs from the original adt
let cfg_attrs = adt
.attrs()
.filter(|attr| attr.as_simple_call().map(|(name, _arg)| name == "cfg").unwrap_or(false));
for attr in cfg_attrs {
impl_.add_attr(attr.clone_for_update());
}
add_cfg_attrs_to(adt, &impl_);

impl_
}

pub(crate) fn add_cfg_attrs_to<T, U>(from: &T, to: &U)
where
T: HasAttrs,
U: AttrsOwnerEdit,
{
let cfg_attrs =
from.attrs().filter(|attr| attr.as_simple_call().is_some_and(|(name, _arg)| name == "cfg"));
for attr in cfg_attrs {
to.add_attr(attr.clone_for_update());
}
}

pub(crate) fn add_method_to_adt(
builder: &mut SourceChangeBuilder,
adt: &ast::Adt,