fix: In "Wrap return type" assist, don't wrap exit points if they already have the right type #20061
+133
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have the right type
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
commented
Jun 22, 2025
| @@ -605,29 +634,39 @@ fn foo() -> Option<i32> { | |||
| check_assist_by_label( | |||
| wrap_return_type, | |||
| r#" | |||
| //- minicore: option | |||
There was a problem hiding this comment.
This needed to change because previously the type was the error type, which unifies with anything.
|
I didn't change anything about on-type enter, so I will re-run CI, but if we're close to the limit maybe we should look at it. |
Veykril
approved these changes
Jun 24, 2025
I think something happened around two weeks ago, it's been failing a lot more often than it used to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20045.