feat: implement Go to Assignments for local variables #20481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
sgasho
force-pushed
the
feat/18149_goto_assignments_local_vars
branch
2 times, most recently
from
ce84d56 to
8748702
Compare
sgasho
force-pushed
the
feat/18149_goto_assignments_local_vars
branch
from
8748702 to
fbc6269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #18149
Summary
"Go to Assignments" for local variables as an initial implementation.
New detections like field accesses can be added to crates/ide/src/goto_assignments.rs but I wanted to reduce the diffs for this PR.
I'm gonna add other detections in another PR.
Evidence
for codes like this,
we can select "Go to Assignments",
and all assignments, including def, are shown.
The "a" in println() is not shown because it is not an assignment.