Precise macro value type #3323
Open
Precise macro value type #3323
+344
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingxiangfei2009
force-pushed
the
precise-macro-value-type
branch
from
4d459ec to
a10ba8a
Compare
Contributor
Author
|
Apparently the clang fallback has race condition. If I set thread number to 1, we don't have truncated output anymore. |
40 tasks
Contributor
Author
|
I have a theory about the test setup leading to the racing. The test setup uses the fallback translation unit backed by a file, which is located in Update: yes, the two tests are racing on writing into the precompiled header. |
dingxiangfei2009
force-pushed
the
precise-macro-value-type
branch
5 times, most recently
from
4d04b3a to
2de8281
Compare
Contributor
Author
|
r? @emilio 🙏 |
emilio
approved these changes
Dec 11, 2025
Contributor
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
Looks good, some (optional) nits.
Contributor
Author
dingxiangfei2009
left a comment
dingxiangfei2009
left a comment
There was a problem hiding this comment.
Are there any outstanding concerns about this PR?
dingxiangfei2009
force-pushed
the
precise-macro-value-type
branch
from
2de8281 to
52d05ca
Compare
Upon activating the `--macro-const-use-ctypes` flag, `bindgen` should generate bindings with precise type resolution to the exact C types. This flag implies `--clang-macro-fallback` as its pre-requisite. Signed-off-by: Xiangfei Ding <dingxiangfei2009@protonmail.ch>
dingxiangfei2009
force-pushed
the
precise-macro-value-type
branch
from
52d05ca to
71f212b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #923.
Fix #3200. This is due to a fallout from how
libclangtype would be processed with this patch.This patch introduce a new generator flag
--macro-const-use-ctypes, which resolves the macro definition expression to a precise type advised by Clang if activated.A macro expansion result adapter is introduced to maintain compatibility with
cexpr, which has a limited capacity to resolve to a precise C type.There is a change to the testing code because up to this point our tests, which can be executed concurrently, use the same path to the precomputed headers. Since this patch introduces a second test that relies on
libclangmacro fallback, the precompiled headers from the two different tests would overwrite each other. The new addition is that the backing files are now temporarily stored at different directories named after the header files under tests.