Repository navigation
RegexSet: combine the build_with_diagnostics() implementations - #3515
Open
DanielEScherzer wants to merge 1 commit into
Open
DanielEScherzer wants to merge 1 commit into
DanielEScherzer wants to merge 1 commit into
Conversation
Contributor
Author
|
Clippy failures are unrelated, #3514 |
emilio
approved these changes
Oct 14, 2026
Contributor
|
Can you rebase? |
The `RegexSet` struct had two different conditionally-compiled versions of the `build_with_diagnostics()` function, one when both the "__cli" feature and the "experimental" feature were enabled, and the other when the "experimental" feature was enabled but the "__cli" feature was not. The actual implementations were identical, and the only difference was that the version when the "__cli" feature was enabled had backticks in its documentation around `RegexSet`. Use a single implementation when the "experimental" feature is enabled, regardless of whether the "__cli" feature is enabled; keep the version with the backticks in the documentation, and update its `#[cfg]` attribute.
DanielEScherzer
force-pushed
the
RegexSet-build_with_diagnostics
branch
from
October 19, 2026 22:00
97169e0 to
93b3fdc
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RegexSetstruct had two different conditionally-compiled versions of thebuild_with_diagnostics()function, one when both the "__cli" feature and the "experimental" feature were enabled, and the other when the "experimental" feature was enabled but the "__cli" feature was not. The actual implementations were identical, and the only difference was that the version when the "__cli" feature was enabled had backticks in its documentation aroundRegexSet.Use a single implementation when the "experimental" feature is enabled, regardless of whether the "__cli" feature is enabled; keep the version with the backticks in the documentation, and update its
#[cfg]attribute.