Repository navigation
Peel all array dimensions in clang::Type::is_const - #3521
Merged
Merged
Conversation
Previously, ir/var.rs and ir/ty.rs only peeled a single array layer when checking whether a ConstantArray or IncompleteArray had const-qualified elements. As a result, multidimensional const arrays (e.g. `extern const int baz[1][1];` or `extern const int qux[][1];`) were emitted as `pub static mut`, and 3D+ const array parameters were emitted as `*mut`. Move the array-peeling loop into `clang::Type::is_const` so all callers handle arbitrary-dimensional constant and incomplete arrays consistently.
Contributor
Author
|
r? @emilio |
emilio
approved these changes
Oct 14, 2026
Contributor
Author
|
Thank you for the quick review, much appreciated! 🙏 😃 🍰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, ir/var.rs and ir/ty.rs only peeled a single array layer when checking whether a ConstantArray or IncompleteArray had const-qualified elements. As a result, multidimensional const arrays (e.g.
extern const int baz[1][1];orextern const int qux[][1];) were emitted aspub static mut, and 3D+ const array parameters were emitted as*mut.Move the array-peeling loop into
clang::Type::is_constso all callers handle arbitrary-dimensional constant and incomplete arrays consistently.