incompatible_msrv: lint function calls with any argument count
#14216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
incompatible-msrv-fix
branch
2 times, most recently
from
b04242c to
ab08d1a
Compare
samueltardieu
force-pushed
the
incompatible-msrv-fix
branch
3 times, most recently
from
90bc6d3 to
efad358
Compare
|
r? @llogiq |
samueltardieu
force-pushed
the
incompatible-msrv-fix
branch
from
efad358 to
3fb9b88
Compare
The lint for function calls was previously restricted to functions taking exactly one argument. This was not documented. Generalizing the lint to an arbitrary number of arguments in the function call requires special casing some macro expansions from the standard library. Macros such as `panic!()` or `assert_eq!()` exist since Rust 1.0.0, but modern stdlib expand those macros into calls to functions introduced in later Rust versions. While it is desirable to lint code inside macros, using MSRV-incompatible functions coming from `core` in macro expansions has been special-cased to not trigger this lint. Also, code coming from compiler desugaring may contain function calls (for example, `a..=b` is now desugared into `RangeInclusive::new(a, b)`. Those should not be linted either as the compiler is allowed to use unstable function calls.
samueltardieu
force-pushed
the
incompatible-msrv-fix
branch
from
3fb9b88 to
c3d5f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint for function calls was previously restricted to functions taking exactly one argument. This was not documented.
Generalizing the lint to an arbitrary number of arguments in the function call requires special casing some macro expansions from the standard library. Macros such as
panic!()orassert_eq!()exist since Rust 1.0.0, but modern stdlib expand those macros into calls to functions introduced in later Rust versions. While it is desirable to lint code inside macros, using MSRV-incompatible functions coming fromcorein macro expansions has been special-cased to not trigger this lint.Also, code coming from compiler desugaring may contain function calls (for example,
a..=bis now desugared intoRangeInclusive::new(a, b). Those should not be linted either as the compiler is allowed to use unstable function calls.Fix #14212
changelog: [
incompatible_msrv]: lint function calls with any argument count