Deprecate match_on_vec_items lint
#14217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-outvnnuossmq
branch
2 times, most recently
from
609321b to
7caf0c9
Compare
This lint does more harm than good: in its description, it proposes to rewrite `match` on `Vec<_>` indexes or slices by a version which cannot panic but masks the failure by choosing the default variant. The `clippy::indexing_slicing` restriction lint covers those cases more safely, by suggesting to use a non-panicking version to retrieve the value from the container, without suggesting to fallback to the default success variant in case of failure.
samueltardieu
force-pushed
the
push-outvnnuossmq
branch
from
7caf0c9 to
1da567b
Compare
|
Rebased |
flip1995
approved these changes
Apr 7, 2025
|
Merging since @llogiq didn't object and there is one approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint does more harm than good: in its description, it proposes to rewrite
matchonVec<_>indexes or slices by a version which cannot panic but masks the failure by choosing the default variant.The
clippy::indexing_slicingrestriction lint covers those cases more safely, by suggesting to use a non-panicking version to retrieve the value from the container, without suggesting to fallback to the default success variant in case of failure.This PR is an (opposite) alternative to #14208 (which will add a suggestion to the lint matching the lint description). Discussion on both PRs can be found on Zulip.
changelog: [
match_on_vec_items]: deprecate lint