Skip to content

Fix false positive of borrow_deref_ref #14967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

Fix false positive of borrow_deref_ref #14967

merged 1 commit into from
Jun 20, 2025

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Jun 4, 2025 •
edited by rustbot
Loading

If a reborrow is itself borrowed mutably, do not propose to replace it by the original reference.

Fixes: #14934

changelog: [borrow_deref_ref]: do not propose replacing a reborrow by the original reference if the reborrow is itself mutably borrowed

@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 4, 2025
y21
y21 reviewed Jun 11, 2025
View reviewed changes
@samueltardieu
Fix false positive of borrow_deref_ref
322e139 
If a reborrow is itself borrowed mutably, do not propose to replace it
by the original reference.
@samueltardieu samueltardieu requested a review from y21 June 12, 2025 17:15
y21
y21 approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@y21 y21 added this pull request to the merge queue Jun 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2025
@y21 y21 added this pull request to the merge queue Jun 20, 2025
Merged via the queue into rust-lang:master with commit 35026c7 Jun 20, 2025
11 checks passed
@samueltardieu samueltardieu deleted the issue-14934 branch June 21, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 approved these changes

Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FP borrow_deref_ref
3 participants
@samueltardieu @rustbot @y21