Skip to content

Fix capacity overflow in single_match with deref patterns #15124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2025
Merged

Fix capacity overflow in single_match with deref patterns #15124

merged 2 commits into from
Jul 20, 2025

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Jun 24, 2025 •
edited by rustbot
Loading

Fixes #14882

changelog: [single_match]: fix ICE with deref patterns and string literals

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 24, 2025
@blyxyas
Copy link
Member

blyxyas commented Jul 11, 2025

Alexendoo's a little bit over the top on capacity (32 assigned PRs)
I'll shave off his last uncommented PRs.

r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned Alexendoo Jul 11, 2025
blyxyas
blyxyas requested changes Jul 12, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great starting patch! Some more testing would be appreciated, and a question.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 12, 2025
@notriddle
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 14, 2025
blyxyas
blyxyas reviewed Jul 20, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ 🌈

@blyxyas blyxyas added this pull request to the merge queue Jul 20, 2025
Merged via the queue into rust-lang:master with commit 56de455 Jul 20, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 20, 2025
@notriddle notriddle deleted the single_match branch July 21, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: capacity overflow
4 participants
@notriddle @rustbot @blyxyas @Alexendoo