Skip to content

Conversation

samueltardieu
Copy link
Member

This feature adds a handy link to each review message (it doesn't create a new comment) that allows the reviewer or other people to check what has been changed in the PR since the review took place.

changelog: none

r? flip1995

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2025
@samueltardieu
Copy link
Member Author

Example: rust-lang/rust#145924 (review)

The advantage, compared to GitHub's compare button, is that it is cumulative should other changes take place.

@flip1995
Copy link
Member

I also saw that in the Rust repo. Isn't this redundant with the range-diff? Wouldn't it make sense to implement the range-diff in this way?

All questions for triagebot. But I think this is nice to have in the repo!

@flip1995 flip1995 added this pull request to the merge queue Aug 28, 2025
@samueltardieu
Copy link
Member Author

I also saw that in the Rust repo. Isn't this redundant with the range-diff? Wouldn't it make sense to implement the range-diff in this way?

They are different: range-diff summarizes what has changed even though a rebase occurred, while this option shows all changes that happened since a review happened.

One advantage is, for example, if you make a review and the submitter pushes several changes, you can see a summary of the changes between the version you reviewed and the new one. Both options "solve" different problems.

Merged via the queue into rust-lang:master with commit c0f29d7 Aug 28, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 28, 2025
@samueltardieu samueltardieu deleted the review-changes-since branch August 30, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants