unnecessary_{find,filter}_map: make diagnostic spans more precise
#15929
+83
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ada4a
force-pushed
the
unnecessary_filter_map
branch
from
bedcc8d to
3fa518c
Compare
ada4a
changed the title
unnecessary_filter_map: make diagnostic spans more preciseunnecessary_{find,filter}_map: make diagnostic spans more precise
ada4a
force-pushed
the
unnecessary_filter_map
branch
2 times, most recently
from
aad18c8 to
018e0e2
Compare
ada4a
force-pushed
the
unnecessary_filter_map
branch
from
018e0e2 to
0410ad2
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Actually, @ada4a can you help to squash the commits? |
|
I'd prefer to keep the last commit separate, as it's the one that contains the actual changes, while the first two are a general clean-up and thus could be squashed together. Would that be okay for you? |
ada4a
force-pushed
the
unnecessary_filter_map
branch
from
0410ad2 to
9145cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
unnecessary_find_map]: make diagnostic spans more precisechangelog: [
unnecessary_filter_map]: make diagnostic spans more precise