-
Notifications
You must be signed in to change notification settings - Fork 245
Improved instructions & docker permissions fix #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I don't mind taking the documentation/style improvements, but I see no reason to change the Dockerfile. Notably, building the containers works fine on both my machine and in CI. At the moment, it seems more likely to me that you have something unique to your environment that needs to be figured out. |
Oh, I'm more than happy to find out what misconfiguration I have, causing permission issues in Docker that get fixed by my first commit. I don't say that to be rude, I genuinely feel that. Do you have any idea? Anyways, I care way more about the documentation/style improvements being accepted because I feel that they may help potential newcomer contributors and people like me who just want to play with it locally. Thank you for your response. |
Nope, because you never stated what the errors were 😉. It may also be useful to share what version of Docker you are using. |
Yeah sorry I forgot to mention that. The first tests I did running rust-playground was in a Digital Ocean VPS running Ubuntu 25.10 with Docker template, while I was away and didn't have access to a real Linux machine. It seems like it was a misconfiguration on their part or mine, but since these patches fixed those, I just included them just in case, in was a general issue. A local run I'm doing right now, seems to go without issues even after I reverted those changes. The only related logs I could find from that VPS said some like that: Step 32/51 : RUN cargo chef prepare
---> Running in a1505111e42d
Error: Failed to save recipe to 'recipe.json'
Caused by:
0: failed to create file recipe.json
1: Permission denied (os error 13)
The command '/bin/sh -c cargo chef prepare' returned a non-zero code: 1
Error: Failed to cook recipe.
Caused by:
0: failed to create file /orchestrator/Cargo.lock
1: Permission denied (os error 13)
cargo run --release Error: The IO queue task failed
Caused by this error:
1: Failed to receive worker messageAnyways, I reverted the docker file changes. |
This PR is a direct consequence of these two #1172 and #1173.
It changes the following:
Dockerfilethat runs withcompiler/build.sh.README.md.README.mdto improve readability.ui/README.mdabout having to set the server's address to0.0.0.0to expose it to the world.README.mdthat highlights:Important
When running the server, you may see some docker warnings about missing containers. You can safely ignore them. You shouldn't see any docker containers running most of the time. This is normal. You don't need to spawn or kill any containers yourself. The backend manages that itself.