Fix tests, a CI issue, a template bug, and clean stuff up #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template asks people to leave this field blank, but CI validates it's present and valid.
Some rows use html comments to mark special tokens to be replaced, but they only show up in the markdown source, not on the website. Some people are copying the template from the website, so the rows are missing from the PRs. We encode the values in the markdown, so they show up on the web, and add a note to make sure to use the unencoded values if copying from source.
lqd
changed the title
lqd
commented
Jun 14, 2025
this will help people who pass the path to the ./src/ milestone.
nikomatsakis
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikomatsakis this PR fixes the failing tests I mentioned before, removes unneeded dependencies, removes unneeded crates, etc thanks to the simpler architecture and needs that we now have.
Maybe more importantly, this also fixes the CI issue seen in #311:
checkensures that the tracking issue id is filled when the row is present, but the https://rust-lang.github.io/rust-project-goals/TEMPLATE.html says to leave it blank. So, now if there's a tracking issue it's validated, and if there's none it's fine -- unless the goal is an accepted goal: we require one for these to link from the goal page to github.This also fixes another issue seen in #311, the goal template is using HTML comments in the markdown for its special computed values magic tokens. If people are copying from https://rust-lang.github.io/rust-project-goals/TEMPLATE.html then the rows will be empty. So I've encoded these magic values in the markdown, and added a note to make sure to use the raw values if someone is copying from the .md which should not happen imho so we're good. That should be enough.
I also added a validation of the milestone passed to
cargo rpg updatesto avoid cases where a path to./src/$milestoneis passed in lieu of e.g.2025h1, which sometimes happens to me, but does nothing without errors.And finally, while checking the goal validation procedure, I noticed the 2025h1 goals hadn't been marked as accepted, so I also did that.
Rendered