Skip to content

Allow using Range as an Iterator in const contexts. #104100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2023
Merged

Allow using Range as an Iterator in const contexts. #104100

merged 2 commits into from
Mar 19, 2023

Conversation

@onestacked
Copy link
Contributor

@onestacked onestacked commented Nov 7, 2022 •
edited
Loading

based on #102225 by @fee1-dead

@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2022

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2022
@onestacked
Copy link
Contributor Author

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onestacked
Copy link
Contributor Author

#104113 should fix the build failure

@bors
Copy link
Collaborator

bors commented Nov 8, 2022

☔ The latest upstream changes (presumably #104138) made this pull request unmergeable. Please resolve the merge conflicts.

@onestacked onestacked force-pushed the const_iter_range branch 3 times, most recently from c6daf89 to be4dfe6 Compare November 9, 2022 16:15
@bors
Copy link
Collaborator

bors commented Nov 10, 2022

☔ The latest upstream changes (presumably #104246) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Nov 13, 2022

☔ The latest upstream changes (presumably #104370) made this pull request unmergeable. Please resolve the merge conflicts.

@onestacked onestacked force-pushed the const_iter_range branch 2 times, most recently from c46b110 to 835b21c Compare November 14, 2022 11:02
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@onestacked onestacked force-pushed the const_iter_range branch 2 times, most recently from 713266c to 50e63de Compare November 14, 2022 14:00
@bors
Copy link
Collaborator

bors commented Nov 19, 2022

☔ The latest upstream changes (presumably #102795) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Dec 10, 2022

☔ The latest upstream changes (presumably #105512) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 9, 2023
@the8472
Copy link
Member

the8472 commented Mar 10, 2023 •
edited
Loading

Modulo the #[cfg((bootstrap)] this is small enough from a libs maintenance perspective. My understanding is that the Destruct stuff will go away at some point. The bootstrap bump PR is already open, we can wait for that.

Handing off to @fee1-dead for the "do we want this in const eval" part (which probably is a rubber-stamp).

@the8472 the8472 requested a review from fee1-dead March 10, 2023 20:36
fee1-dead
fee1-dead requested changes Mar 11, 2023
View reviewed changes
@onestacked onestacked force-pushed the const_iter_range branch 2 times, most recently from ca30cbd to 03b07a9 Compare March 11, 2023 12:09
@fee1-dead
Copy link
Member

LGTM after fixing CI

@onestacked onestacked requested a review from fee1-dead March 18, 2023 15:27
@fee1-dead
Copy link
Member

@bors r=the8472,fee1-dead

@bors
Copy link
Collaborator

bors commented Mar 18, 2023

📌 Commit 8a9d6bf has been approved by the8472,fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 19, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2023
@bors
Auto merge of rust-lang#109346 - Dylan-DPC:rollup-vszi5bn, r=Dylan-DPC
8826b68 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#104100 (Allow using `Range` as an `Iterator` in const contexts. )
 - rust-lang#105793 (Add note for mismatched types because of circular dependencies)
 - rust-lang#108798 (move default backtrace setting to sys)
 - rust-lang#108829 (Use Edition 2021 :pat in matches macro)
 - rust-lang#108973 (Beautify pin! docs)
 - rust-lang#109003 (Add `useless_anonymous_reexport` lint)
 - rust-lang#109022 (read_buf_exact: on error, all read bytes are appended to the buffer)
 - rust-lang#109212 (fix: don't suggest similar method when unstable)
 - rust-lang#109243 (The name of NativeLib will be presented)
 - rust-lang#109324 (Implement FixedSizeEncoding for UnusedGenericParams.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 993b775 into rust-lang:master Mar 19, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 19, 2023
@onestacked onestacked deleted the const_iter_range branch March 19, 2023 22:37
@madsmtm madsmtm mentioned this pull request Mar 20, 2023
Closed
yvt added a commit to r3-os/r3 that referenced this pull request Mar 21, 2023
@yvt
refactor(core): use Range: const Iterator and const_for
261914a 
[rust-lang/rust#104100][1] has implemented `std::ops::Range: const
Iterator`, resolving `[tag:range_const_iterator]`.

[1]: rust-lang/rust#104100
@frewsxcv
Copy link
Contributor

FYI this change broke the objc2 crate madsmtm/objc2#432

@the8472
Copy link
Member

the8472 commented Mar 25, 2023

You should open an issue for that, comments on merged PRs won't get much attention.

@lukas-code lukas-code mentioned this pull request Mar 26, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2023
@bors
Auto merge of rust-lang#109684 - fee1-dead-contrib:rv_const_range, r=…
1c39afb 
…Mark-Simulacrum

Revert rust-lang#104100, Allow using `Range` as an `Iterator` in const contexts.

This fixes rust-lang#109632.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@the8472 the8472 the8472 approved these changes

@fee1-dead fee1-dead Awaiting requested review from fee1-dead

Assignees

@the8472 the8472

@fee1-dead fee1-dead

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.70.0

Development

Successfully merging this pull request may close these issues.

9 participants

@onestacked @rustbot @rust-log-analyzer @bors @the8472 @apiraino @fee1-dead @frewsxcv @scottmcm