- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
Support AIX-style archive type #106704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AIX-style archive type #106704
Conversation
| 
          
 (rustbot has picked a reviewer for you, use r? to override)  | 
    
          
  | 
    
| 
           Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any  Examples of  
  | 
    
| 
           ☔ The latest upstream changes (presumably #106646) made this pull request unmergeable. Please resolve the merge conflicts.  | 
    
cc74b7d    to
    a341fcf      
    Compare
  
    a341fcf    to
    0f7cdc4      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
0f7cdc4    to
    a1390f5      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| 
           Ah, it fails because LLVM 13 does not have support for   | 
    
| 
           You can wait for #107573 which will bump the minimum supported LLVM version to 14.  | 
    
a1390f5    to
    cefaf5d      
    Compare
  
    | 
           These commits modify the  If this was intentional then you can ignore this comment.  | 
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| 
           💔 Test failed - checks-actions  | 
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| 
           Discussed in this week's triage meeting. We think the PR author needs to update the tests to pass CI. @rustbot label: +S-waiting-on-author -S-waiting-on-review  | 
    
| 
           ☔ The latest upstream changes (presumably #109133) made this pull request unmergeable. Please resolve the merge conflicts.  | 
    
| 
           @bors r+  | 
    
| 
           ☀️ Test successful - checks-actions  | 
    
| 
           Finished benchmarking commit (39c6804): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with  @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment. 
 Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment. 
 CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment. 
  | 
    
| 
           Since this PR doesn't have actually change to code flow, the regression should come from something newly imported into   | 
    
| 
           Yeah, the triage here is effectively "wow, the tests seem like they've gotten a lot more variance lately, because this sure as heck shouldn't have actually changed anything worth writing home about. Maaayyybe it perturbed some of std's code?". @rustbot label: +perf-regression-triaged  | 
    
Reading facility of AIX big archive has been supported by
objectsince 0.30.0.Writing facility of AIX big archive has already been supported by
ar_archive_writer, but we need to bump the version to support the new archive type enum.