Skip to content

Conversation

@Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Mar 2, 2024

This reverts #118488 as that is just a workaround.

Blocked on rust-lang/rustc-rayon#12 to avoid deadlocks.

@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 2, 2024
@rust-log-analyzer

This comment has been minimized.

@matthiaskrgr matthiaskrgr added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 2, 2024
@Dylan-DPC Dylan-DPC removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2024
@bors
Copy link
Collaborator

bors commented Apr 1, 2025

☔ The latest upstream changes (presumably #137535) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc marked this pull request as ready for review September 25, 2025 11:50
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2025
@apiraino
Copy link
Contributor

apiraino commented Oct 9, 2025

@Zoxc I assume the S-blocked label can be now lifted, correct?

You and cc: @matthiaskrgr probably know why it was applied.

@rustbot label -S-blocked

@rustbot rustbot removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Oct 9, 2025
@matthiaskrgr
Copy link
Member

I added the label because of "Blocked on rust-lang/rustc-rayon#12 to avoid deadlocks."

looks like the upstream pr has not been merged to this day

@Zoxc
Copy link
Contributor Author

Zoxc commented Oct 9, 2025

Yeah, it can be unblocked since #143035 landed.

It does regress performance now, so I'll have to do some profiling to see if that can be fixed.

BenchmarkBeforeAfterBeforeAfterBeforeAfter
TimeTime%Physical MemoryPhysical Memory%Committed MemoryCommitted Memory%
🟣 clap:check0.4302s0.4326s 0.56%202.12 MiB202.34 MiB 0.11%282.69 MiB283.03 MiB 0.12%
🟣 hyper:check0.1157s0.1174s💔 1.48%129.28 MiB129.19 MiB -0.06%209.59 MiB209.58 MiB -0.01%
🟣 regex:check0.2558s0.2591s💔 1.29%162.13 MiB162.35 MiB 0.13%237.77 MiB238.03 MiB 0.11%
🟣 syn:check0.4937s0.4960s 0.46%196.09 MiB196.26 MiB 0.08%272.40 MiB272.54 MiB 0.05%
Total1.2954s1.3051s 0.75%689.62 MiB690.14 MiB 0.07%1002.45 MiB1003.17 MiB 0.07%
Summary1.0000s1.0095s 0.95%1 byte1.00 bytes 0.07%1 byte1.00 bytes 0.07%

@wesleywiser wesleywiser added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants