Skip to content

Conversation

Rejyr
Copy link
Contributor

@Rejyr Rejyr commented Jun 16, 2024

llvm_readobj.rs seems unused from the migration to llvm.rs in #125165.
Also, llvm.rs was missing the drop bombs (#125752) in llvm_readobj.rs.

Part of #121876.

r? @jieyouxu

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2024

The run-make-support library was changed

cc @jieyouxu

@jieyouxu
Copy link
Member

Oh huh, I totally missed that, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 16, 2024

📌 Commit eb0bad4 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 16, 2024
Rollup of 8 pull requests

Successful merges:

 - rust-lang#126178 (Weekly `cargo update`)
 - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target)
 - rust-lang#126365 (Honor collapse_debuginfo for statics.)
 - rust-lang#126524 (bump few deps)
 - rust-lang#126536 (Remove unused `llvm_readobj.rs` in `run-make-support`)
 - rust-lang#126546 (std: move `sys_common::backtrace` to `sys`)
 - rust-lang#126560 (more ice tests)
 - rust-lang#126561 (`boxed_slice_into_iter`: tiny doc correction)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0ff790f into rust-lang:master Jun 16, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 16, 2024
Rollup merge of rust-lang#126536 - Rejyr:remove-unused-run-make-file, r=jieyouxu

Remove unused `llvm_readobj.rs` in `run-make-support`

`llvm_readobj.rs` seems unused from the migration to `llvm.rs` in rust-lang#125165.
Also, `llvm.rs` was missing the drop bombs (rust-lang#125752) in `llvm_readobj.rs`.

Part of rust-lang#121876.

r? `@jieyouxu`
@Rejyr Rejyr deleted the remove-unused-run-make-file branch June 17, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants