Migrate emit-to-stdout run-make test to rmake#128460
Migrate emit-to-stdout run-make test to rmake#128460Oneirical wants to merge 2 commits intorust-lang:masterfrom
emit-to-stdout run-make test to rmake#128460Conversation
This comment has been minimized.
This comment has been minimized.
|
Note to self: look at the pseudoterminal stuff |
|
Note that the test does not necessarily need |
|
Btw, on windows this can be done via |
|
Progress update: none, since I haven't gotten to this one yet, lol |
5a9a84d to
73560f5
Compare
73560f5 to
47e9643
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Review notes: |
There was a problem hiding this comment.
Suggestion: rename this test to rustc-emit-to-stdout or something, since apparently there's a emit-shared-files test which is exercising rustdoc only (where I suggested to rename that test to rustdoc-emit-shared-files as well).
|
Here's my (very quick) implementation that might work on Linux. I've not tested it though. df8d4ba It works on Windows but note the "fixme". |
|
Closing this in favor of #131355 where we consolidated all of the efforts for |
Part of #121876 and the associated Google Summer of Code project.
Another test which will fail CI. Most of everything here works, with the only exception being the cases where the test redirects stdout to a tty:
1>/dev/ptmx.run_make_supportdoesn't support this yet, so I am posting this PR to open a discussion.