Skip to content

Prereq2 for async drop - ResumedAfterDrop panic messages #129736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Prereq2 for async drop - ResumedAfterDrop panic messages #129736

wants to merge 2 commits into from

Conversation

@azhogin
Copy link
Contributor

@azhogin azhogin commented Aug 29, 2024 •
edited
Loading

This is subpart 2 PR of #123948, just for review purposes.

ResumedAfterDrop messages for panic when coroutine is resumed after it is started to be async drop'ed.

Review only last commit, based on previous PR #129734

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2024

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

This was referenced Aug 29, 2024
Closed
Merged
@azhogin azhogin marked this pull request as draft August 30, 2024 07:14
@azhogin azhogin force-pushed the azhogin/async-drop-prereq2-resumed-after-drop-msg branch from aca1a66 to 286f4c0 Compare August 30, 2024 07:16
@azhogin azhogin force-pushed the azhogin/async-drop-prereq2-resumed-after-drop-msg branch 2 times, most recently from 99b7c82 to edaf9ce Compare September 8, 2024 12:01
@bors
Copy link
Collaborator

bors commented Sep 23, 2024

☔ The latest upstream changes (presumably #130724) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco
Copy link
Member

r? @nikomatsakis is going to look into this

@rustbot rustbot assigned nikomatsakis and unassigned davidtwco Oct 1, 2024
@azhogin azhogin force-pushed the azhogin/async-drop-prereq2-resumed-after-drop-msg branch from edaf9ce to 53a9086 Compare February 8, 2025 17:57
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin azhogin force-pushed the azhogin/async-drop-prereq2-resumed-after-drop-msg branch from 53a9086 to a858408 Compare February 8, 2025 21:13
@bors
Copy link
Collaborator

bors commented Feb 9, 2025

☔ The latest upstream changes (presumably #136751) made this pull request unmergeable. Please resolve the merge conflicts.

@azhogin azhogin force-pushed the azhogin/async-drop-prereq2-resumed-after-drop-msg branch from a858408 to 746589b Compare February 10, 2025 13:29
@bors
Copy link
Collaborator

bors commented Feb 12, 2025

☔ The latest upstream changes (presumably #136943) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk assigned oli-obk and unassigned nikomatsakis Mar 12, 2025
@azhogin azhogin force-pushed the azhogin/async-drop-prereq2-resumed-after-drop-msg branch from 746589b to 5d1ad9b Compare March 30, 2025 16:48
@bors
Copy link
Collaborator

bors commented Apr 5, 2025

☔ The latest upstream changes (presumably #139417) made this pull request unmergeable. Please resolve the merge conflicts.

@azhogin azhogin force-pushed the azhogin/async-drop-prereq2-resumed-after-drop-msg branch from 5d1ad9b to 40d29b3 Compare April 6, 2025 07:50
@azhogin azhogin force-pushed the azhogin/async-drop-prereq2-resumed-after-drop-msg branch from 40d29b3 to 92d848f Compare April 6, 2025 10:02
@oli-obk oli-obk closed this Apr 28, 2025
@petrochenkov petrochenkov added the F-async_drop `#![feature(async_drop)]` label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

F-async_drop `#![feature(async_drop)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@azhogin @rustbot @bors @davidtwco @rust-log-analyzer @nikomatsakis @oli-obk @petrochenkov