Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break from review rotation #132866

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

jieyouxu
Copy link
Member

Spending ~a week to focus on:

  • Digesting remaining Makefiles (so close yet so far).
  • 2024 Q3 T-compiler P-high issues review pre-triage.
  • Some docs for rustc-dev-guide.

r? @ghost

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@jieyouxu
Copy link
Member Author

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 10, 2024

📌 Commit e49d917 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 10, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#131781 (Stabilize Arm64EC inline assembly)
 - rust-lang#132426 (Prefer `pub(super)` in `unreachable_pub` lint suggestion)
 - rust-lang#132866 (Break from review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bf62717 into rust-lang:master Nov 10, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 10, 2024
Rollup merge of rust-lang#132866 - jieyouxu:review-rotation-break, r=jieyouxu

Break from review rotation

Spending ~a week to focus on:

- Digesting remaining `Makefile`s (so close yet so far).
- 2024 Q3 T-compiler P-high issues review pre-triage.
- Some docs for rustc-dev-guide.

r? `@ghost`
@rustbot rustbot added this to the 1.84.0 milestone Nov 10, 2024
@jieyouxu jieyouxu deleted the review-rotation-break branch November 11, 2024 06:49
mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
…jieyouxu

Break from review rotation

Spending ~a week to focus on:

- Digesting remaining `Makefile`s (so close yet so far).
- 2024 Q3 T-compiler P-high issues review pre-triage.
- Some docs for rustc-dev-guide.

r? `@ghost`
mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#131781 (Stabilize Arm64EC inline assembly)
 - rust-lang#132426 (Prefer `pub(super)` in `unreachable_pub` lint suggestion)
 - rust-lang#132866 (Break from review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants