Enable automatic cross-compilation in run-make tests #139244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
jieyouxu
added
S-experimental
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
…<try> [WIP] [WIP] Enable automatic cross-compilation in run-make tests WIP for the WIP rust-lang#138066. Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: i686-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #139257) made this pull request unmergeable. Please resolve the merge conflicts. |
jieyouxu
force-pushed
the
exp/auto-cross-run-make
branch
from
c09efec to
9140e31
Compare
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2025
…<try> [WIP] [WIP] Enable automatic cross-compilation in run-make tests WIP for the WIP rust-lang#138066. Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: i686-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
|
Aaaaa I accidentally clicked again 💀 |
jieyouxu
removed
the
S-waiting-on-author
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
☔ The latest upstream changes (presumably #139242) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
jieyouxu
force-pushed
the
exp/auto-cross-run-make
branch
from
9140e31 to
520d534
Compare
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2025
…=<try> [WIP] Enable automatic cross-compilation for run-make rustdoc tests Extracted out of rust-lang#139244. Helps with rust-lang#138066. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 13, 2025
…<try> [WIP] [WIP] Enable automatic cross-compilation in run-make tests WIP for the WIP rust-lang#138066. Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
bors
added a commit
that referenced
this pull request
Jun 18, 2025
Enable automatic cross-compilation in run-make tests Supersedes #138066. Blocker for #141856. Based on #138066 plus `rustdoc()` cross-compile changes. ### Summary This PR automatically specifies `--target` to `rustc()` and `rustdoc()` to have `rustc`/`rustdoc` produce cross-compiled artifacts in run-make tests by default, unless: - `//@ ignore-cross-compile` is used, or - `bare_{rustc,rustdoc}` are used, or - Explicit `.target()` is specified, which overrides the default cross-compile target. Some tests are necessarily modified: - Tests that have `.target(target())` have that incantation removed (since this is now automatically the default). - Some tests have `//@ needs-target-std`, but are a necessary-but-insufficient condition, and are changed to `//@ ignore-cross-compile` instead as host-only tests. - A few tests received `//@ ignore-musl` that fail against `x86_64-unknown-linux-musl` because of inability to find `-lunwind`. AFAICT, they don't *need* to test cross-compiled artifacts. - Some tests are constrained to host-only for now, because the effort to make them pass on cross-compile does not seem worth the complexity, and it's not really *meaningfully* improving test coverage. try-job: armhf-gnu try-job: test-various
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
jieyouxu
force-pushed
the
exp/auto-cross-run-make
branch
from
3f77eaa to
2beccc4
Compare
|
@bors2 try |
|
❌ Encountered an error while executing command |
jieyouxu
added
S-waiting-on-author
|
@bors2 try jobs=dist-various-1 |
rust-bors bot
added a commit
that referenced
this pull request
Jun 18, 2025
Enable automatic cross-compilation in run-make tests Supersedes #138066. Blocker for #141856. Based on #138066 plus `rustdoc()` cross-compile changes. ### Summary This PR automatically specifies `--target` to `rustc()` and `rustdoc()` to have `rustc`/`rustdoc` produce cross-compiled artifacts in run-make tests by default, unless: - `//@ ignore-cross-compile` is used, or - `bare_{rustc,rustdoc}` are used, or - Explicit `.target()` is specified, which overrides the default cross-compile target. Some tests are necessarily modified: - Tests that have `.target(target())` have that incantation removed (since this is now automatically the default). - Some tests have `//@ needs-target-std`, but are a necessary-but-insufficient condition, and are changed to `//@ ignore-cross-compile` instead as host-only tests. - A few tests received `//@ ignore-musl` that fail against `x86_64-unknown-linux-musl` because of inability to find `-lunwind`. AFAICT, they don't *need* to test cross-compiled artifacts. - Some tests are constrained to host-only for now, because the effort to make them pass on cross-compile does not seem worth the complexity, and it's not really *meaningfully* improving test coverage. try-job: dist-various-1 try-job: dist-various-1
|
@bors r=Kobzol |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 8a65ee0 (parent) -> 70e2b4a (this PR) Test differencesShow 112 test diffsStage 2
(and 12 additional test diffs) Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 70e2b4a4d197f154bed0eb3dcb5cac6a948ff3a3 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (70e2b4a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 692.997s -> 691.846s (-0.17%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #138066.
Blocker for #141856.
Based on #138066 plus
rustdoc()cross-compile changes.Summary
This PR automatically specifies
--targettorustc()andrustdoc()to haverustc/rustdocproduce cross-compiled artifacts in run-make tests by default, unless://@ ignore-cross-compileis used, orbare_{rustc,rustdoc}are used, or.target()is specified, which overrides the default cross-compile target.Some tests are necessarily modified:
.target(target())have that incantation removed (since this is now automatically the default).//@ needs-target-std, but are a necessary-but-insufficient condition, and are changed to//@ ignore-cross-compileinstead as host-only tests.//@ ignore-muslthat fail againstx86_64-unknown-linux-muslbecause of inability to find-lunwind. AFAICT, they don't need to test cross-compiled artifacts.try-job: dist-various-1