Skip to content

Bump boostrap compiler to new beta #139279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 10, 2025
Merged

Bump boostrap compiler to new beta #139279

merged 7 commits into from
Apr 10, 2025

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Apr 2, 2025 •
edited by jieyouxu
Loading

try-job: *msvc*

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

BoxyUwU
BoxyUwU commented Apr 2, 2025
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Apr 2, 2025

ok does it really need to reping everyone every time i push lol

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@matthiaskrgr
Copy link
Member

ok does it really need to reping everyone every time i push lol

might help to mark it as a draft 🤔

@sayantn sayantn mentioned this pull request Apr 2, 2025
Merged
@jieyouxu
Copy link
Member

jieyouxu commented Apr 6, 2025 •
edited
Loading

Waiting to hear back on #139279 (comment) cc @m-ou-se (friendly ping).

jieyouxu
jieyouxu approved these changes Apr 6, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

jieyouxu commented Apr 6, 2025

@bors r+ rollup=never p=1 (bootstrap compiler bump)

@bors
Copy link
Collaborator

bors commented Apr 6, 2025

📌 Commit 0afd9eb has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2025
@bors
Auto merge of rust-lang#139279 - BoxyUwU:bump-boostrap, r=jieyouxu
c211655 
Bump boostrap compiler to new beta
@bors
Copy link
Collaborator

bors commented Apr 7, 2025

⌛ Testing commit 0afd9eb with merge c211655...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 8, 2025

☀️ Try build successful - checks-actions
Build commit: 2277df8 (2277df8b33b72959072228acc7eefdfc07dbb8d8)

@Kobzol
Copy link
Member

Kobzol commented Apr 9, 2025 •
edited
Loading

The conflicts are probably from #139378.

@jieyouxu
Copy link
Member

jieyouxu commented Apr 9, 2025

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 9, 2025

📌 Commit 5a5bda5 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 9, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Apr 9, 2025

@bors p=6 (blocking more work so scheduling ahead of rollups)

@bors
Copy link
Collaborator

bors commented Apr 10, 2025

⌛ Testing commit 5a5bda5 with merge 6813f95...

@bors
Copy link
Collaborator

bors commented Apr 10, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 6813f95 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 10, 2025
@bors bors merged commit 6813f95 into rust-lang:master Apr 10, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 51548ce (parent) -> 6813f95 (this PR)

Test differences

Show 141 test diffs

Stage 0

  • pin_macro::temp_lifetime: [missing] -> pass (J0)

Additionally, 140 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Job duration changes

  1. x86_64-apple-2: 4064.7s -> 5640.7s (38.8%)
  2. x86_64-apple-1: 7227.9s -> 8149.1s (12.7%)
  3. dist-x86_64-linux: 5048.5s -> 5520.8s (9.4%)
  4. dist-arm-linux: 5396.3s -> 5796.9s (7.4%)
  5. dist-loongarch64-linux: 6848.1s -> 6352.3s (-7.2%)
  6. dist-x86_64-apple: 9764.9s -> 9127.4s (-6.5%)
  7. dist-apple-various: 9511.7s -> 8919.7s (-6.2%)
  8. x86_64-msvc-ext1: 7695.6s -> 7258.3s (-5.7%)
  9. aarch64-gnu-debug: 4018.8s -> 4186.1s (4.2%)
  10. x86_64-gnu-llvm-19-1: 5407.7s -> 5205.2s (-3.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Apr 10, 2025
Merged
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6813f95): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 0.2% [0.2%, 0.2%] 2
Regressions ❌
(secondary)		 0.3% [0.2%, 1.1%] 27
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 2

Max RSS (memory usage)

Results (secondary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.1% [-4.1%, -2.2%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.069s -> 780.636s (0.07%)
Artifact size: 366.22 MiB -> 366.13 MiB (-0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Apr 10, 2025
@Mark-Simulacrum
Copy link
Member

Spot-checking a few of the regressions, they're returns to pre-existing levels (i.e., this is bimodality not actual regression).

@Mark-Simulacrum Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Apr 14, 2025
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 19, 2025
@bors
Auto merge of rust-lang#139279 - BoxyUwU:bump-boostrap, r=jieyouxu
9054e9d 
Bump boostrap compiler to new beta

try-job: `*msvc*`
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 28, 2025
@bors
Auto merge of #139474 - jieyouxu:bump-rustc-perf, r=Kobzol
891597b 
rustc-perf: update to `c0f3b53c8e5de87714d18a5f42998859302ae03a`

Hopefully unblocks rust-lang/rust#139279.

r? `@Kobzol` (or compiler)
`@bors` rollup=never
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. O-windows Operating system: Windows perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
10 participants
@BoxyUwU @rustbot @rust-log-analyzer @matthiaskrgr @jieyouxu @bors @Kobzol @rust-timer @Mark-Simulacrum @m-ou-se