Rollup of 7 pull requests #141011
Open
Rollup of 7 pull requests #141011
+194
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was showing compare mode instead of test name.
Signed-off-by: xizheyin <[email protected]>
Signed-off-by: xizheyin <[email protected]>
They will be used in Clippy to detect runtime parsing of known-valid IP addresses.
…e, r=oli-obk Do not ICE when reassigning in GatherLocalsVisitor on the bad path Fixes rust-lang#140785 Fixes rust-lang#140730 See comment in code. r? oli-obk
…Mark-Simulacrum Add an issue template for future-incompatible lints This adds a GitHub issue template for future-incompatible lints. Most of the existing tracking issues have been using different formats with different information, and I think it would be helpful to make them a little more consistent and to ensure that sufficient information is provided. Some comments on my choices: * Added a dedicated section to describe *why* the change is being made. Many existing issues already have this, so let's standardize on it. * Have a section with a very clear example. Almost all of the existing issues have this in one form or another. * Added a "Recommendations" section, since this is something I see missing in several of the existing issues, and this is really important information IMHO. * I reworded the "When" section. The existing template mentioned that these get reviewed every 6 weeks which my understanding is not true. That's also not very helpful information to the user, since it doesn't really answer the question. I'm not sure this section will actually be useful since I suspect most of the time we don't know when it will change (there have been a few exceptions). * Clearly show the expected progression steps. Several issues already have this. * Added implementation history, which is useful for linking PRs. (IDK, this could get merged with "Steps".)
…compiler-errors Fix a compiletest blessing message It was showing compare mode instead of test name. Fixes rust-lang#140945. Noticed in rust-lang#140622 (comment).
…=jieyouxu Update rustix to 1.0.7 for bootstrap Another bump for bootstrap. Finally it compiles on Cygwin:) Hooray! r? ``@jieyouxu``
…Urgau Add `Ipv4Addr` and `Ipv6Addr` diagnostic items They will be used in Clippy to detect runtime parsing of known-valid IP addresses.
…, r=tgross35 MaybeUninit::write: fix doc # Fix doc for `MaybeUninit::write` The documentation refers to the way `MaybeUninit` stores data internally. The property of not dropping content on context exit is the responsibility of `ManuallyDrop`.
…errors Suggest replace f with f: Box<f> when expr field is short hand Fixes rust-lang#139631 r? compiler
rustbot
added
A-compiletest
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#140827 (Do not ICE when reassigning in GatherLocalsVisitor on the bad path) - rust-lang#140904 (Add an issue template for future-incompatible lints) - rust-lang#140953 (Fix a compiletest blessing message) - rust-lang#140973 (Update rustix to 1.0.7 for bootstrap) - rust-lang#140976 (Add `Ipv4Addr` and `Ipv6Addr` diagnostic items) - rust-lang#140988 (MaybeUninit::write: fix doc) - rust-lang#140989 (Suggest replace f with f: Box<f> when expr field is short hand) r? `@ghost` `@rustbot` modify labels: rollup
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
This was referenced May 14, 2025
|
FWIW, AFAIK it's still possible to get merges through: you just have to be slightly lucky and roll the 20250504 windows server 2025 image instead of the 20250427 image :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Ipv4AddrandIpv6Addrdiagnostic items #140976 (AddIpv4AddrandIpv6Addrdiagnostic items)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup