Skip to content

Fixed a typo in ManuallyDrop's doc #141873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Fixed a typo in ManuallyDrop's doc #141873

merged 1 commit into from
Jun 3, 2025

Conversation

neeko-cat
Copy link
Contributor

I noticed a typo in ManuallyDrop's documentation (someone wrote "iff" instead of "if"). I fixed it in this PR.

@rustbot
Copy link
Collaborator

rustbot commented Jun 1, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 1, 2025
@tgross35
Copy link
Contributor

tgross35 commented Jun 2, 2025 •
edited
Loading

Thanks for the PR, but this is likely intentional. "iff" is a common shorthand for "if and only if".

This is a code block comment anyway, typos aren't very harmful. But thank you for the PR! More help is always welcome.

@tgross35 tgross35 closed this Jun 2, 2025
@neeko-cat
Copy link
Contributor Author

Oops... that makes sense, my bad!

@tgross35
Copy link
Contributor

tgross35 commented Jun 2, 2025

Not a problem :) take a look at issues labeled E-easy if you are looking to get started with some Rust development https://github.com/rust-lang/rust/issues?q=is%3Aissue%20state%3Aopen%20label%3AE-easy, or drop by on Zulip https://rust-lang.zulipchat.com/

@neeko-cat
Copy link
Contributor Author

Woah thanks! I honestly wasn't expecting you to be as friendly, if everyone around here is like you, I might consider getting involved :)

@ShE3py
Copy link
Contributor

ShE3py commented Jun 2, 2025

Someone made the exact same PR last week (#141416), so maybe un-shorthanding it is okay? This also seems like the only doc-comment containing iff (https://github.com/search?q=repo:rust-lang/rust+path:library+"+iff+"&type=code), and as most translations are word-for-word (https://www.wikidata.org/wiki/Q949972), it will helps comprehension.

@tgross35
Copy link
Contributor

tgross35 commented Jun 2, 2025

Thanks for linking that, I'll just merge this then.

As a note, we tend to avoid accepting tiny typo fix PRs because of problems we have had with bot commit farming. But the user has interacted here and apparently it's causing confusion, so might as well change it. Just try to include typo fixes with something slightly more substantial (e.g. like other doc improvements / clarification) next time :)

"if" reads better than "if and only if" in the context anyway IMO.

@tgross35 tgross35 reopened this Jun 2, 2025
@tgross35
Copy link
Contributor

tgross35 commented Jun 2, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit c5e758d has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
@workingjubilee
Rollup merge of rust-lang#141873 - neeko-cat:patch-1, r=tgross35
121fb7a 
Fixed a typo in `ManuallyDrop`'s doc

I noticed a typo in `ManuallyDrop`'s documentation (someone wrote "iff" instead of "if"). I fixed it in this PR.
@workingjubilee workingjubilee mentioned this pull request Jun 3, 2025
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
@workingjubilee
Rollup merge of rust-lang#141873 - neeko-cat:patch-1, r=tgross35
beba312 
Fixed a typo in `ManuallyDrop`'s doc

I noticed a typo in `ManuallyDrop`'s documentation (someone wrote "iff" instead of "if"). I fixed it in this PR.
@workingjubilee workingjubilee mentioned this pull request Jun 3, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 3, 2025
Merged
bors added a commit that referenced this pull request Jun 3, 2025
@bors
Auto merge of #141944 - matthiaskrgr:rollup-e7xhp6w, r=matthiaskrgr
c68032f 
Rollup of 8 pull requests

Successful merges:

 - #140715 (Clarify &mut-methods' docs on sync::OnceLock)
 - #141677 (Async drop - type instead of async drop fn, fixes #140484)
 - #141741 (Overhaul `UsePath`)
 - #141873 (Fixed a typo in `ManuallyDrop`'s doc)
 - #141876 (Don't declare variables in `ExprKind::Let` in invalid positions)
 - #141886 (Add missing 2015 edition directives)
 - #141889 (Add missing `dyn` keywords to tests that do not test for them)
 - #141891 (Fix borrowck mentioning a name from an external macro we (deliberately) don't save)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6a5459e into rust-lang:master Jun 3, 2025
18 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 3, 2025
rust-timer added a commit that referenced this pull request Jun 3, 2025
@rust-timer
Unrolled build for #141873
e9b293e 
Rollup merge of #141873 - neeko-cat:patch-1, r=tgross35

Fixed a typo in `ManuallyDrop`'s doc

I noticed a typo in `ManuallyDrop`'s documentation (someone wrote "iff" instead of "if"). I fixed it in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@neeko-cat @rustbot @tgross35 @ShE3py @bors