resolve: Tweak private_macro_use
lint to be compatible with upcoming macro prelude changes
#141934
+36
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #139493.
Zulip thread requesting help - #t-compiler/help > Help requested for effects of #139493.
This PR by itself shouldn't cause any observable changes, its only observable effect is that the prelude changes from #139493 will no longer cause regressions in tests like
tests/ui/imports/issue-119369.rs
ortests/ui/extern/issue-80074.rs
.This is achieved by moving the "is this thing in stdlib prelude" check from an early point (
fn process_macro_use_imports
) to a later point (fn record_use_inner
), at which the stdlib prelude is already populated and can be inspected.(The
is_builtin_macro
check is subsumed by the stdlib prelude check, all built-in macros go through the stdlib prelude anyway.)