Skip to content

rustdoc: Support middle::ty associated const equality predicates again #142092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

rustdoc: Support middle::ty associated const equality predicates again #142092

merged 2 commits into from
Jun 6, 2025
+106 −132

Conversation

fmease
Copy link
Member

@fmease fmease commented Jun 5, 2025 •
edited by rustbot
Loading

Fix intentional regression from PR #125076.

Fixes #125092.
Fixes #134775.

CC #141368 (EqPredicates and rustdoc).

@fmease fmease added the F-associated_const_equality `#![feature(associated_const_equality)]` label Jun 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fmease fmease moved this to In Progress in Associated Const Equality (ACE) Jun 5, 2025
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jun 5, 2025
@fmease fmease changed the title Support middle::ty associated const equality predicates again rustdoc: Support middle::ty associated const equality predicates again Jun 5, 2025
@fmease fmease removed A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jun 5, 2025
@GuillaumeGomez
Copy link
Member

Looks good to me, thanks!

r=me once CI pass

@fmease
Copy link
Member Author

fmease commented Jun 5, 2025

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented Jun 5, 2025

📌 Commit 95bf127 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 5, 2025
@GuillaumeGomez
Rollup merge of rust-lang#142092 - fmease:rustdoc-alias-terms, r=Guil…
b2dbd07 
…laumeGomez

rustdoc: Support middle::ty associated const equality predicates again

Fix intentional regression from PR rust-lang#125076.

Fixes rust-lang#125092.
Fixes rust-lang#134775.

CC rust-lang#141368 (`EqPredicates` and rustdoc).
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 5, 2025
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 5, 2025
Merged
bors added a commit that referenced this pull request Jun 6, 2025
@bors
Auto merge of #142099 - matthiaskrgr:rollup-r9s3c35, r=matthiaskrgr
2082a82 
Rollup of 11 pull requests

Successful merges:

 - #125087 (Optimize `Seek::stream_len` impl for `File`)
 - #141982 (`tests/ui`: A New Order [5/N])
 - #142012 (Replace some `Option<Span>` with `Span` and use DUMMY_SP instead of None)
 - #142044 (compiler: Document the offset invariant of `OperandValue::Pair`)
 - #142047 (Ensure stack in two places that affect s390x)
 - #142058 (Clean `rustc_attr_parsing/src/lib.rs` documentation)
 - #142067 (canon_abi: make to_erased_extern_abi just a detail in formatting)
 - #142072 (doc: Fix inverted meaning in E0783.md)
 - #142084 (add myself to rotation)
 - #142091 (Fix AIX build)
 - #142092 (rustdoc: Support middle::ty associated const equality predicates again)

Failed merges:

 - #142042 (Make E0621 missing lifetime suggestion verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jun 6, 2025
@bors
Auto merge of #142099 - matthiaskrgr:rollup-r9s3c35, r=matthiaskrgr
16ca0cb 
Rollup of 11 pull requests

Successful merges:

 - #125087 (Optimize `Seek::stream_len` impl for `File`)
 - #141982 (`tests/ui`: A New Order [5/N])
 - #142012 (Replace some `Option<Span>` with `Span` and use DUMMY_SP instead of None)
 - #142044 (compiler: Document the offset invariant of `OperandValue::Pair`)
 - #142047 (Ensure stack in two places that affect s390x)
 - #142058 (Clean `rustc_attr_parsing/src/lib.rs` documentation)
 - #142067 (canon_abi: make to_erased_extern_abi just a detail in formatting)
 - #142072 (doc: Fix inverted meaning in E0783.md)
 - #142084 (add myself to rotation)
 - #142091 (Fix AIX build)
 - #142092 (rustdoc: Support middle::ty associated const equality predicates again)

Failed merges:

 - #142042 (Make E0621 missing lifetime suggestion verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jun 6, 2025
@bors
Auto merge of #142099 - matthiaskrgr:rollup-r9s3c35, r=matthiaskrgr
f315e61 
Rollup of 11 pull requests

Successful merges:

 - #125087 (Optimize `Seek::stream_len` impl for `File`)
 - #141982 (`tests/ui`: A New Order [5/N])
 - #142012 (Replace some `Option<Span>` with `Span` and use DUMMY_SP instead of None)
 - #142044 (compiler: Document the offset invariant of `OperandValue::Pair`)
 - #142047 (Ensure stack in two places that affect s390x)
 - #142058 (Clean `rustc_attr_parsing/src/lib.rs` documentation)
 - #142067 (canon_abi: make to_erased_extern_abi just a detail in formatting)
 - #142072 (doc: Fix inverted meaning in E0783.md)
 - #142084 (add myself to rotation)
 - #142091 (Fix AIX build)
 - #142092 (rustdoc: Support middle::ty associated const equality predicates again)

Failed merges:

 - #142042 (Make E0621 missing lifetime suggestion verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e12572f into rust-lang:master Jun 6, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jun 6, 2025
@rust-timer
Unrolled build for #142092
db81709 
Rollup merge of #142092 - fmease:rustdoc-alias-terms, r=GuillaumeGomez

rustdoc: Support middle::ty associated const equality predicates again

Fix intentional regression from PR #125076.

Fixes #125092.
Fixes #134775.

CC #141368 (`EqPredicates` and rustdoc).
@github-project-automation github-project-automation bot moved this from In Progress to Done in Associated Const Equality (ACE) Jun 6, 2025
@rustbot rustbot added this to the 1.89.0 milestone Jun 6, 2025
@fmease fmease deleted the rustdoc-alias-terms branch June 6, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
F-associated_const_equality `#![feature(associated_const_equality)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
Associated Const Equality (ACE)
Status: Done
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

rustdoc: ICE: Cannot turn UnevaluatedConst into AliasTy when synthesizing auto trait impls Assoc const equality doesn't work well with rustdoc
4 participants
@fmease @rustbot @GuillaumeGomez @bors