add track_caller attribute to map_err and ok_or/_else #142093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation unicode-org/icu4x#4048
This PR resolves a common edge case where users attempting to manually track
std::panic::Location
s of their callers in theirError
types end up with irrelevant locations inside ofstd
.The main concern with this approach that I'm aware of is that
#[track_caller]
increases the stack sizes of the functions it is applied to, though I think this is a non-issue since we already have#[track_caller]
onResult
'sFromResidual
impl which is used far more frequently than any of these APIs when converting errors between different types. This change brings these functions in line with that impl.example demonstrating the issue: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=8205bcd02b380d9fd02b1f1153ac9c4e