Use a distinct ToString implementation for u128 and i128
#142294
+112
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #136594) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
specialize-tostring-on-128-integers
branch
from
b5b6654 to
53dc659
Compare
|
Fixed merge conflicts. |
workingjubilee
changed the title
ToString implementation on u128 and i128ToString implementation for u128 and i128
|
Having done code review of things that use Rust's |
|
Noted, thanks for the title update then. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #135543.
Follow-up of #136264.
When working on #142098, I realized that
i128andu128could also benefit from a distinctToStringimplementation so here it.The last commit is just me realizing that I forgot to add the format tests for
usizeandisize.