-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[WIP] Use weak aliases for the allocator shim #142366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in coverage instrumentation. cc @Zalathar |
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
@bors2 try cancel forgot to fix warnings.... @bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
Try build cancelled. Cancelled workflows: |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
Some changes occurred in compiler/rustc_codegen_gcc |
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
All test failures seem to involve LTO. I suspect that the |
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
So close...
The exit code is STATUS_DLL_NOT_FOUND, no idea why stripping breaks things. |
☔ The latest upstream changes (presumably #142259) made this pull request unmergeable. Please resolve the merge conflicts. |
Cleaned up a bit. Let's see if it didn't regress anything. @bors2 try |
[WIP] Use weak aliases for the allocator shim
@bors2 try cancel |
Try build cancelled. Cancelled workflows: |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed
|
Use the .drectve section for exporting symbols from dlls on Windows While it would be reasonable to expect the Windows linker to handle linker args in the .drectve section identical to cli arguments, as it turns out exporting weak symbols only works when the /EXPORT is in the .drectve section, not when it is a linker argument or when a .DEF file is used. Necessary for and extracted out of #142366. Thanks `@dpaoliello` for figuring out this weird quirk of link.exe! try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
No description provided.