Update to LLVM 20.1.7 #142447

dianqk · 2025-06-13T06:48:31Z

Closes #141306, closes #140686, closes #141737, closes #140933.

rustbot · 2025-06-13T06:48:36Z

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-06-13T06:48:39Z

⚠️ Warning ⚠️

Some commits in this PR modify submodules.

dianqk · 2025-06-13T06:52:17Z

@bors p=1

nikic · 2025-06-13T08:39:18Z

@bors r+ rollup=never

bors · 2025-06-13T08:39:20Z

📌 Commit 4b2e77b has been approved by nikic

It is now in the queue for this repository.

Update to LLVM 20.1.7 Closes #141306, closes #140686, closes #141737, closes #140933.

bors · 2025-06-13T21:24:43Z

⌛ Testing commit 4b2e77b with merge 5a64ee7...

rust-log-analyzer · 2025-06-13T22:57:41Z

The job x86_64-gnu-nopt failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_driver v0.0.0 (/checkout/compiler/rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 13.682
error: linking with `cc` failed: exit status: 1
  |
  = note:  "cc" "-m64" "/tmp/rustcQeqaKB/symbols.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bdynamic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_driver-788ba4279e0f4b2c.so" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/{libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lrt" "-ldl" "-lm" "-lstdc++" "-ldl" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustcQeqaKB/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/psm-333143ff6fcbb6a0/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/blake3-c8ecf418975a8dbd/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/blake3-c8ecf418975a8dbd/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm-40d55c9b90cb9de2/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/lib" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_main-940eb4e3ed3321b0" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-nodefaultlibs" "-Wl,-z,origin" "-Wl,-rpath,$ORIGIN/../lib"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: /usr/bin/ld: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_driver-788ba4279e0f4b2c.so: undefined reference to `llvm::EnableABIBreakingChecks'
          /usr/bin/ld: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_driver-788ba4279e0f4b2c.so: undefined reference to `llvm::Error::fatalUncheckedError() const'
          collect2: error: ld returned 1 exit status

bors · 2025-06-13T22:58:17Z

💔 Test failed - checks-actions

dianqk · 2025-06-14T02:08:52Z

@bors retry

Update to LLVM 20.1.7 Closes #141306, closes #140686, closes #141737, closes #140933.

bors · 2025-06-14T07:57:35Z

⌛ Testing commit 4b2e77b with merge b940ffb...

rust-log-analyzer · 2025-06-14T09:31:26Z

The job x86_64-gnu-nopt failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_driver v0.0.0 (/checkout/compiler/rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 13.737
error: linking with `cc` failed: exit status: 1
  |
  = note:  "cc" "-m64" "/tmp/rustcutyBmU/symbols.o" "<1 object files omitted>" "-Wl,--as-needed" "-Wl,-Bdynamic" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_driver-e248548c82f77832.so" "-Wl,-Bstatic" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib/{libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lrt" "-ldl" "-lm" "-lstdc++" "-ldl" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/tmp/rustcutyBmU/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/psm-333143ff6fcbb6a0/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/blake3-c8ecf418975a8dbd/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/blake3-c8ecf418975a8dbd/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/rustc_llvm-40d55c9b90cb9de2/out" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/lib" "-L" "<sysroot>/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_main-6d2f3c57c15fe6d9" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-nodefaultlibs" "-Wl,-z,origin" "-Wl,-rpath,$ORIGIN/../lib"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: /usr/bin/ld: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_driver-e248548c82f77832.so: undefined reference to `llvm::EnableABIBreakingChecks'
          /usr/bin/ld: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_driver-e248548c82f77832.so: undefined reference to `llvm::Error::fatalUncheckedError() const'
          collect2: error: ld returned 1 exit status

bors · 2025-06-14T09:32:05Z

💔 Test failed - checks-actions

nikic · 2025-06-14T09:39:41Z

The build is configured with --enable-llvm-assertions, but then we pass "-DLLVM_ENABLE_ASSERTIONS=OFF" to cmake...

We end up with rustc thinking LLVM was build with assertions even though it wasn't.

nikic · 2025-06-14T09:43:50Z

I'm gonna guess it's related to this extra config file

rust/src/ci/docker/host-x86_64/x86_64-gnu-nopt/Dockerfile

Line 32 in 64033a4

    
           ENV SCRIPT python3 ../x.py test --stage 1 --config /config/nopt-std-config.toml library/std \

and the stage redesign in some way... (cc @Kobzol @onur-ozkan)

jieyouxu · 2025-06-14T13:35:38Z

Looking into that.

jieyouxu · 2025-06-14T17:43:03Z

#142516 should unblock this PR (hopefully)

apiraino · 2025-06-16T09:38:50Z

Given the issues this patch fixes, I'll nominate for beta backport. But in less than 10 days we have the release, unsure if it has time to bake (or has a lot sense per se backporting) .

@rustbot label beta-nominated

Fix `-nopt` CI jobs They were using `--config` instead of `--set`, which overrides too much stuff after recent changes to config merging. Should hopefully unblock rust-lang#142447. r? `@jieyouxu`

Rollup merge of #142566 - Kobzol:ci-nopt-fix, r=jieyouxu Fix `-nopt` CI jobs They were using `--config` instead of `--set`, which overrides too much stuff after recent changes to config merging. Should hopefully unblock #142447. r? `@jieyouxu`

Kobzol · 2025-06-16T17:53:14Z

@bors2 try jobs=x86_64-gnu-nopt

rust-bors · 2025-06-16T17:53:18Z

⌛ Trying commit 4b2e77b with merge 7a7ff85…

To cancel the try build, run the command @bors2 try cancel.

Update to LLVM 20.1.7 Closes #141306, closes #140686, closes #141737, closes #140933. try-job: x86_64-gnu-nopt

rust-bors · 2025-06-16T20:21:20Z

☀️ Try build successful (CI)
Build commit: 7a7ff85 (7a7ff8516a217ff3896efcf8c3462c3e9b9799bd, parent: 3bc767e1a215c4bf8f099b32e84edb85780591b1)

nikic · 2025-06-16T20:32:39Z

@bors r+

bors · 2025-06-16T20:32:42Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: Rollup of 8 pull requests #142589

bors · 2025-06-16T20:32:43Z

📌 Commit 4b2e77b has been approved by nikic

It is now in the queue for this repository.

jieyouxu · 2025-06-16T21:08:34Z

@bors p=5 (rollup scheduling; fixes a P-critical)

bors · 2025-06-16T22:33:42Z

⌛ Testing commit 4b2e77b with merge 55d4364...

bors · 2025-06-17T01:37:22Z

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 55d4364 to master...

github-actions · 2025-06-17T01:40:11Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 45acf54 (parent) -> 55d4364 (this PR)

Test differences

Show 10 test diffs

Stage 2

[assembly] tests/assembly/riscv-soft-abi-with-float-features.rs#LLVM-PRE-20: ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) (J0)
[assembly] tests/assembly/sanitizer/kcfi/emit-arity-indicator.rs#x86_64: ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.7 is older than 21.0.0) (J0)
[assembly] tests/assembly/x86_64-bigint-helpers.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) (J0)
[codegen] tests/codegen/integer-cmp.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) (J0)
[codegen] tests/codegen/issues/issue-101082.rs#x86-64-v3: ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.7 is older than 21.0.0) (J0)
[codegen] tests/codegen/option-niche-eq.rs#LLVM21: ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.7 is older than 21.0.0) (J0)
[codegen] tests/codegen/sanitizer/kcfi/add-kcfi-arity-flag.rs#x86_64: ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.7 is older than 21.0.0) (J0)
[assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-DEBUG: ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) (J1)
[assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-OPTIM: ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.7) is newer than majorversion 19) (J1)
[run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J2)

Job group index

J0: aarch64-apple, aarch64-gnu, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
J1: test-various, x86_64-apple-1, x86_64-gnu, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
J2: x86_64-gnu-nopt

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 55d436467c351b56253deeba209ae2553d1c243f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 7363.1s -> 10192.3s (38.4%)
mingw-check-tidy: 70.5s -> 52.7s (-25.2%)
test-various: 4629.6s -> 5666.1s (22.4%)
mingw-check-2: 2102.7s -> 2510.8s (19.4%)
mingw-check-1: 1960.0s -> 2314.9s (18.1%)
x86_64-rust-for-linux: 2994.3s -> 3532.9s (18.0%)
armhf-gnu: 4819.8s -> 5575.6s (15.7%)
dist-apple-various: 8256.2s -> 6977.3s (-15.5%)
x86_64-gnu: 7018.8s -> 8011.8s (14.1%)
x86_64-apple-2: 6380.3s -> 5524.1s (-13.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-17T03:49:31Z

Finished benchmarking commit (55d4364): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 756.938s -> 756.784s (-0.02%)
Artifact size: 372.14 MiB -> 372.10 MiB (-0.01%)

Fix `-nopt` CI jobs They were using `--config` instead of `--set`, which overrides too much stuff after recent changes to config merging. Should hopefully unblock rust-lang/rust#142447. r? `@jieyouxu`

Update to LLVM 20.1.7

4b2e77b

rustbot assigned cuviper Jun 13, 2025

rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2025

bors added a commit that referenced this pull request Jun 13, 2025

Auto merge of #142447 - dianqk:llvm-20.1.7, r=nikic

5a64ee7

Update to LLVM 20.1.7 Closes #141306, closes #140686, closes #141737, closes #140933.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 13, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 14, 2025

bors added a commit that referenced this pull request Jun 14, 2025

Auto merge of #142447 - dianqk:llvm-20.1.7, r=nikic

b940ffb

Update to LLVM 20.1.7 Closes #141306, closes #140686, closes #141737, closes #140933.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 14, 2025

jieyouxu mentioned this pull request Jun 14, 2025

Specify NO_LLVM_ASSERTIONS for *-nopt jobs #142516

Closed

Kobzol mentioned this pull request Jun 16, 2025

Fix -nopt CI jobs #142566

Merged

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 16, 2025

apiraino added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jun 16, 2025

rust-bors bot added a commit that referenced this pull request Jun 16, 2025

Auto merge of #142447 - dianqk:llvm-20.1.7, r=<try>

7a7ff85

Update to LLVM 20.1.7 Closes #141306, closes #140686, closes #141737, closes #140933. try-job: x86_64-gnu-nopt

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 17, 2025

bors merged commit 55d4364 into rust-lang:master Jun 17, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 17, 2025

dianqk deleted the llvm-20.1.7 branch June 17, 2025 03:02

Update to LLVM 20.1.7 #142447

Update to LLVM 20.1.7 #142447

Conversation

dianqk commented Jun 13, 2025 • edited by nikic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 13, 2025

Uh oh!

rustbot commented Jun 13, 2025

Uh oh!

dianqk commented Jun 13, 2025

Uh oh!

nikic commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

rust-log-analyzer commented Jun 13, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

dianqk commented Jun 14, 2025

Uh oh!

bors commented Jun 14, 2025

Uh oh!

rust-log-analyzer commented Jun 14, 2025

Uh oh!

bors commented Jun 14, 2025

Uh oh!

nikic commented Jun 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikic commented Jun 14, 2025

Uh oh!

jieyouxu commented Jun 14, 2025

Uh oh!

jieyouxu commented Jun 14, 2025

Uh oh!

apiraino commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Jun 16, 2025

Uh oh!

rust-bors bot commented Jun 16, 2025

Uh oh!

rust-bors bot commented Jun 16, 2025

Uh oh!

nikic commented Jun 16, 2025

Uh oh!

bors commented Jun 16, 2025

Uh oh!

bors commented Jun 16, 2025

Uh oh!

jieyouxu commented Jun 16, 2025

Uh oh!

bors commented Jun 16, 2025

Uh oh!

bors commented Jun 17, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 17, 2025

Test differences

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 17, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

dianqk commented Jun 13, 2025 •

edited by nikic

Loading

nikic commented Jun 14, 2025 •

edited

Loading

apiraino commented Jun 16, 2025 •

edited

Loading