Port #[rustc_pub_transparent] to the new attribute system
#142600
+32
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_attr_parsing |
|
☔ The latest upstream changes (presumably #138165) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/rustc_pub_transparent
branch
from
3a22b8c to
9e7300a
Compare
|
☔ The latest upstream changes (presumably #142697) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
attributes/rustc_pub_transparent
branch
from
9e7300a to
9e2493f
Compare
| @@ -158,6 +158,14 @@ impl<'tcx> CheckAttrVisitor<'tcx> { | |||
| Attribute::Parsed(AttributeKind::AsPtr(attr_span)) => { | |||
| self.check_applied_to_fn_or_method(hir_id, *attr_span, span, target) | |||
| } | |||
| &Attribute::Parsed(AttributeKind::PubTransparent(attr_span)) => { | |||
There was a problem hiding this comment.
this should get its own method (See my comment on #[may_dangle])
|
☔ The latest upstream changes (presumably #142770) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to #142498.
This is a part of #131229, so
r? @jdonszelmann
For reference, the
#[rustc_pub_transparent]attribute was created by me back in #129487.As mentioned back in #129487 (comment), this attribute does not check that it is applied to an ADT, because it checks that
#[repr(transparent)]is also applied to the same item, which, in turn, should check for ADT.