Skip to content

Implement autodiff using intrinsics #142640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Implement autodiff using intrinsics #142640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6108a2d
Lower autodiff functions using instrinsics
Sa4dUs Jun 4, 2025
dc56f2b
Macro expansion with `rustc_intrinsic`
Sa4dUs Jun 5, 2025
fc86dda
Lowering draft
Sa4dUs Jun 17, 2025
10a7c45
Naive impl of intrinsic codegen
Sa4dUs Jun 23, 2025
447c75a
Feature intrinsics in cg tests
Sa4dUs Jun 24, 2025
fad0b0c
Remove `sret` logic
Sa4dUs Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions compiler/rustc_builtin_macros/src/autodiff.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,9 @@ mod llvm_enzyme {
.filter(|a| **a == DiffActivity::Active || **a == DiffActivity::ActiveOnly)
.count() as u32;
let (d_sig, new_args, idents, errored) = gen_enzyme_decl(ecx, &sig, &x, span);
let d_body = gen_enzyme_body(

// UNUSED
let _d_body = gen_enzyme_body(
ecx, &x, n_active, &sig, &d_sig, primal, &new_args, span, sig_span, idents, errored,
&generics,
);
Expand All @@ -342,7 +344,7 @@ mod llvm_enzyme {
ident: first_ident(&meta_item_vec[0]),
generics,
contract: None,
body: Some(d_body),
body: None, // This leads to an error when the ad function is inside a traits
define_opaque: None,
});
let mut rustc_ad_attr =
Expand Down Expand Up @@ -429,12 +431,18 @@ mod llvm_enzyme {
tokens: ts,
});

let rustc_intrinsic_attr =
P(ast::NormalAttr::from_ident(Ident::with_dummy_span(sym::rustc_intrinsic)));
let new_id = ecx.sess.psess.attr_id_generator.mk_attr_id();
let intrinsic_attr = outer_normal_attr(&rustc_intrinsic_attr, new_id, span);

let new_id = ecx.sess.psess.attr_id_generator.mk_attr_id();
let d_attr = outer_normal_attr(&rustc_ad_attr, new_id, span);
let d_annotatable = match &item {
Annotatable::AssocItem(_, _) => {
let assoc_item: AssocItemKind = ast::AssocItemKind::Fn(asdf);
let d_fn = P(ast::AssocItem {
attrs: thin_vec![d_attr, inline_never],
attrs: thin_vec![d_attr, intrinsic_attr],
id: ast::DUMMY_NODE_ID,
span,
vis,
Expand All @@ -444,13 +452,15 @@ mod llvm_enzyme {
Annotatable::AssocItem(d_fn, Impl { of_trait: false })
}
Annotatable::Item(_) => {
let mut d_fn = ecx.item(span, thin_vec![d_attr, inline_never], ItemKind::Fn(asdf));
let mut d_fn =
ecx.item(span, thin_vec![d_attr, intrinsic_attr], ItemKind::Fn(asdf));
d_fn.vis = vis;

Annotatable::Item(d_fn)
}
Annotatable::Stmt(_) => {
let mut d_fn = ecx.item(span, thin_vec![d_attr, inline_never], ItemKind::Fn(asdf));
let mut d_fn =
ecx.item(span, thin_vec![d_attr, intrinsic_attr], ItemKind::Fn(asdf));
d_fn.vis = vis;

Annotatable::Stmt(P(ast::Stmt {
Expand Down
Loading
Loading