Skip to content

Conversation

@Gankra
Copy link
Contributor

@Gankra Gankra commented Jun 18, 2025

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.


This is a rebase of

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@Gankra
Copy link
Contributor Author

Gankra commented Jun 18, 2025

The previous PR stalled out on concerns of ecosystem breakage, but see this comment for @est31 concluding we can move forward without further mitigation: #125692 (comment)

@Gankra
Copy link
Contributor Author

Gankra commented Jun 18, 2025

I would like to nominate this for FCP or whatever the current process is to land these kinds of major toolchain changes.

Landing this update is expected to resolve ongoing issues in the ecosystem with rootless docker images.

I've also drafted a rust-lang blogpost announcing this change (based on the previous musl update's post).

@jieyouxu
Copy link
Member

jieyouxu commented Jun 18, 2025

The process for bumping the target baseline of Tier 2 targets is currently a Major Change Proposal + FCP (see Changing target baseline (e.g. minimum Darwin or Windows version bump) part). If you draft an MCP, I'll help with the notifying relevant target maintainers part.

Changing target baseline (e.g. minimum Darwin or Windows version bump)

  • Propose using: MCP
  • Approve using: FCP
  • Write an MCP describing why the target should have a change of baseline and once discussion has concluded, an FCP can be started to approve the change of baseline.

@jieyouxu jieyouxu added the needs-mcp This change is large enough that it needs a major change proposal before starting work. label Jun 18, 2025
@jieyouxu
Copy link
Member

r? @wesleywiser (since you've reviewed the previous attempt)

@Gankra
Copy link
Contributor Author

Gankra commented Jun 18, 2025

I have filed an MCP:

@jieyouxu jieyouxu removed the needs-mcp This change is large enough that it needs a major change proposal before starting work. label Jun 18, 2025
@est31 est31 added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 18, 2025
@Noratrieb Noratrieb added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Jun 18, 2025
@workingjubilee
Copy link
Member

Building host compiler plus musl stds for crater run.

@bors try

bors added a commit that referenced this pull request Jun 19, 2025
Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

[musl releases page](https://musl.libc.org/releases.html)

Prior update: #107129

MCP for this change: rust-lang/compiler-team#887

--------

This is a rebase of

* #125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
@bors
Copy link
Collaborator

bors commented Jun 19, 2025

⌛ Trying commit 1926e11 with merge 1271e16...

@bors
Copy link
Collaborator

bors commented Jun 19, 2025

💥 Test timed out

@rust-log-analyzer

This comment has been minimized.

@workingjubilee
Copy link
Member

@bors2 delegate=try

@rust-bors
Copy link

rust-bors bot commented Jun 19, 2025

@Gankra can now perform try builds on this pull request

@Gankra

This comment was marked as outdated.

@rust-rfcbot rust-rfcbot added the disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. label Oct 9, 2025
@rust-rfcbot rust-rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 21, 2025
@rust-rfcbot
Copy link
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

@rust-rfcbot rust-rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 31, 2025
@rust-rfcbot
Copy link
Collaborator

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@Gankra
Copy link
Contributor Author

Gankra commented Oct 31, 2025

LOUD SIREN NOISES

IT'S TIME

@workingjubilee
Copy link
Member

It seems it is indeed time~

@bors r=wesleywiser

@bors
Copy link
Collaborator

bors commented Nov 1, 2025

📌 Commit 010b690 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
…wiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: rust-lang#107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* rust-lang#125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
bors added a commit that referenced this pull request Nov 1, 2025
Rollup of 10 pull requests

Successful merges:

 - #135602 (Tweak output of missing lifetime on associated type)
 - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`)
 - #142682 (Update bundled musl to 1.2.5)
 - #148171 (Simplify code to generate line numbers in highlight)
 - #148263 (Unpin `libc` and `rustix` in `compiler` and `rustbook`)
 - #148301 ([rustdoc search] Include extern crates when filtering on `import`)
 - #148330 (Don't require dlltool with the dummy backend on MinGW)
 - #148338 (cleanup: upstream dropped amx-transpose functionality)
 - #148340 (Clippy subtree update)
 - #148343 (`nonpoison::Condvar` should take `MutexGuard` by reference)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 1, 2025
Rollup of 10 pull requests

Successful merges:

 - #135602 (Tweak output of missing lifetime on associated type)
 - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`)
 - #142682 (Update bundled musl to 1.2.5)
 - #148171 (Simplify code to generate line numbers in highlight)
 - #148263 (Unpin `libc` and `rustix` in `compiler` and `rustbook`)
 - #148301 ([rustdoc search] Include extern crates when filtering on `import`)
 - #148330 (Don't require dlltool with the dummy backend on MinGW)
 - #148338 (cleanup: upstream dropped amx-transpose functionality)
 - #148340 (Clippy subtree update)
 - #148343 (`nonpoison::Condvar` should take `MutexGuard` by reference)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 03dc656 into rust-lang:master Nov 1, 2025
10 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 1, 2025
rust-timer added a commit that referenced this pull request Nov 1, 2025
Rollup merge of #142682 - Gankra:update_musl_1.2.5, r=wesleywiser

Update bundled musl to 1.2.5

Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.

* mcp: rust-lang/compiler-team#887
* blog: rust-lang/blog.rust-lang.org#1641
* Prior update: #107129
* [musl releases page](https://musl.libc.org/releases.html)

--------

This is a rebase of

* #125692

Which removes the second speculative commit which ended up not panning out.

I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.

try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. needs-crater This change needs a crater run to check for possible breakage in the ecosystem. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. to-announce Announce this issue on triage meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.