[perf] Fast path for coercions of TY == TY #142973

compiler-errors · 2025-06-24T17:30:26Z

No description provided.

compiler-errors · 2025-06-24T17:30:32Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-24T17:30:36Z

⌛ Trying commit 5d1b220 with merge 5b86323…

To cancel the try build, run the command @bors2 try cancel.

[perf] Fast path for coercions of TY == TY

compiler-errors · 2025-06-24T18:41:35Z

ugh oops i shouldn't have pushed lol

@bors2 try @rust-timer queue

rust-bors · 2025-06-24T18:41:39Z

⌛ Trying commit 34842e5 with merge 5bbf4be…

(The previously running try build was automatically cancelled.)

To cancel the try build, run the command @bors2 try cancel.

[perf] Fast path for coercions of TY == TY

compiler-errors · 2025-06-24T18:55:11Z

tests/ui/span/regions-close-over-type-parameter-2.stderr

@@ -6,7 +6,6 @@ LL |         let tmp0 = 3;
 LL |         let tmp1 = &tmp0;
   |                    ^^^^^ borrowed value does not live long enough
 LL |         repeater3(tmp1)
-   |         --------------- borrow later captured here by trait object


This suggestion is was never valid. repeater3 is what's responsible for doing the unsizing, and the fact that we were reporting this as capturing A just because it has the signature fn<'a, A: 'a>(A) -> Box<dyn Tr + 'a> is kinda... coincidental.

rust-log-analyzer · 2025-06-24T19:28:25Z

The job aarch64-gnu-llvm-19-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [crashes] tests/crashes/122681.rs ... ok
test [crashes] tests/crashes/122710.rs ... ok
test [crashes] tests/crashes/122903-1.rs ... ok
test [crashes] tests/crashes/122904-2.rs ... ok
2025-06-24T19:28:06.024763Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/123140.rs ... FAILED
test [crashes] tests/crashes/123157.rs ... ok
test [crashes] tests/crashes/123629.rs ... ok
test [crashes] tests/crashes/123690.rs ... ok
test [crashes] tests/crashes/123810.rs ... ok
---
test [crashes] tests/crashes/125801.rs ... ok
test [crashes] tests/crashes/122823.rs ... ok
test [crashes] tests/crashes/125841.rs ... ok
test [crashes] tests/crashes/126268.rs ... ok
2025-06-24T19:28:06.833949Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/126269.rs ... FAILED
test [crashes] tests/crashes/126443.rs ... ok
test [crashes] tests/crashes/126667.rs ... ok
test [crashes] tests/crashes/126680.rs ... ok
test [crashes] tests/crashes/126696.rs ... ok
---
test [crashes] tests/crashes/130797.rs ... ok
test [crashes] tests/crashes/131046.rs ... ok
test [crashes] tests/crashes/130970.rs ... ok
test [crashes] tests/crashes/131292.rs ... ignored, only executed when the architecture is x86_64
2025-06-24T19:28:07.615682Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/131048.rs ... FAILED
test [crashes] tests/crashes/131295.rs ... ok
test [crashes] tests/crashes/131052.rs ... ok
test [crashes] tests/crashes/131347.rs ... ok
test [crashes] tests/crashes/131373.rs ... ok
---
test [crashes] tests/crashes/133808.rs ... ok
test [crashes] tests/crashes/131342.rs ... ok
test [crashes] tests/crashes/134061.rs ... ok
test [crashes] tests/crashes/133966.rs ... ok
2025-06-24T19:28:08.525556Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/134174.rs ... ok
test [crashes] tests/crashes/134217.rs ... FAILED
test [crashes] tests/crashes/134479.rs ... ok
test [crashes] tests/crashes/134587.rs ... ok
test [crashes] tests/crashes/134654.rs ... ignored, only executed when the architecture is x86_64
---
failures:

---- [crashes] tests/crashes/123140.rs stdout ----

error: crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.

thread '[crashes] tests/crashes/123140.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:
fatal error
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- [crashes] tests/crashes/126269.rs stdout ----

error: crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.

thread '[crashes] tests/crashes/126269.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:
fatal error

---- [crashes] tests/crashes/131048.rs stdout ----

error: crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.

thread '[crashes] tests/crashes/131048.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:
fatal error

---- [crashes] tests/crashes/134217.rs stdout ----

error: crashtest no longer crashes/triggers ICE, hooray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.

thread '[crashes] tests/crashes/134217.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:
fatal error

rust-bors · 2025-06-24T21:11:46Z

☀️ Try build successful (CI)
Build commit: 5bbf4be (5bbf4be1c185dd3063fde118728da0716d13ec7b, parent: 36b21637e93b038453924d3c66821089e71d8baa)

rust-timer · 2025-06-25T15:19:32Z

Finished benchmarking commit (5bbf4be): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	0.6%	[0.3%, 0.7%]	14
Improvements ✅ (primary)	-0.9%	[-5.1%, -0.1%]	85
Improvements ✅ (secondary)	-2.8%	[-12.1%, -0.1%]	83
All ❌✅ (primary)	-0.9%	[-5.1%, 2.9%]	86

Max RSS (memory usage)

Results (primary -2.4%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.5%	[4.1%, 5.2%]	3
Improvements ✅ (primary)	-2.4%	[-5.0%, -0.8%]	9
Improvements ✅ (secondary)	-1.9%	[-2.7%, -1.0%]	8
All ❌✅ (primary)	-2.4%	[-5.0%, -0.8%]	9

Cycles

Results (primary -1.8%, secondary -4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	3.3%	[3.3%, 3.3%]	1
Improvements ✅ (primary)	-1.9%	[-5.1%, -0.6%]	35
Improvements ✅ (secondary)	-5.2%	[-9.5%, -1.1%]	30
All ❌✅ (primary)	-1.8%	[-5.1%, 2.8%]	36

Binary size

Results (primary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.3%, 1.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[-0.0%, 1.1%]	3

Bootstrap: 689.383s -> 688.515s (-0.13%)
Artifact size: 371.94 MiB -> 371.59 MiB (-0.09%)

Fast path for coercions of TY == TY

5d1b220

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 24, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 24, 2025

Auto merge of #142973 - compiler-errors:quick-coerce-2, r=<try>

5b86323

[perf] Fast path for coercions of TY == TY

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 24, 2025

This comment has been minimized.

Sign in to view

Restore error message for one case

34842e5

rust-bors bot added a commit that referenced this pull request Jun 24, 2025

Auto merge of #142973 - compiler-errors:quick-coerce-2, r=<try>

5bbf4be

[perf] Fast path for coercions of TY == TY

This comment has been minimized.

Sign in to view

compiler-errors commented Jun 24, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[perf] Fast path for coercions of TY == TY #142973

[perf] Fast path for coercions of TY == TY #142973

compiler-errors commented Jun 24, 2025

Uh oh!

compiler-errors commented Jun 24, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 24, 2025

Uh oh!

This comment has been minimized.

compiler-errors commented Jun 24, 2025

Uh oh!

rust-bors bot commented Jun 24, 2025

Uh oh!

This comment has been minimized.

compiler-errors Jun 24, 2025

Uh oh!

rust-log-analyzer commented Jun 24, 2025

Uh oh!

rust-bors bot commented Jun 24, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 25, 2025

Uh oh!

Uh oh!

[perf] Fast path for coercions of TY == TY #142973

Are you sure you want to change the base?

[perf] Fast path for coercions of TY == TY #142973

Conversation

compiler-errors commented Jun 24, 2025

Uh oh!

compiler-errors commented Jun 24, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 24, 2025

Uh oh!

This comment has been minimized.

compiler-errors commented Jun 24, 2025

Uh oh!

rust-bors bot commented Jun 24, 2025

Uh oh!

This comment has been minimized.

compiler-errors Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

rust-log-analyzer commented Jun 24, 2025

Uh oh!

rust-bors bot commented Jun 24, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 25, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!