Port the proc macro attributes to the new attribute parsing infrastructure #143607

JonathanBrouwer · 2025-07-07T19:08:31Z

Ports #[proc_macro], #[proc_macro_attribute], #[proc_macro_derive] and #[rustc_builtin_macro] to the new attribute parsing infrastructure for #131229 (comment)

I've split this PR into commits for reviewability, and left some comments to clarify things
I did 4 related attributes in one PR because they share a lot of their code and logic, and doing them separately is kind of annoying as I need to leave both the old and new parsing in place then.

r? @oli-obk
cc @jdonszelmann

JonathanBrouwer · 2025-07-07T19:11:03Z

compiler/rustc_expand/src/base.rs

+
+            // Not a built-in macro
+            None => (None, helper_attrs),
+        };


The logic here should be equivalent to the logic above, other than that this is a bit more readable and that we use the already parsed attribute rather than parsing it from scratch

JonathanBrouwer · 2025-07-07T19:13:59Z

tests/ui/feature-gates/issue-43106-gating-of-builtin-attrs.rs

@@ -57,7 +57,7 @@
 // see gated-link-args.rs
 // see issue-43106-gating-of-macro_escape.rs for crate-level; but non crate-level is below at "2700"
 // (cannot easily test gating of crate-level #[no_std]; but non crate-level is below at "2600")
-#![proc_macro_derive()] //~ WARN `#[proc_macro_derive]` only has an effect
+#![proc_macro_derive(Test)] //~ WARN `#[proc_macro_derive]` only has an effect


Note that a breaking change happened here! The code before this change would now produce an error.

Previously a proc_macro_derive applied to the crate could have any arguments it wants, it was not checked. This PR fixes this bug, and this now errors.

I discussed this privately with @jdonszelmann, and she said this is fine to change, though we can consider doing a crater run for this just to make sure if you wish.

rustbot · 2025-07-07T19:16:51Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

rustbot · 2025-07-07T20:39:47Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

jdonszelmann · 2025-07-07T21:07:32Z

This could use a little squash I think

jdonszelmann · 2025-07-07T21:07:48Z

Not everything, but some commits are a bit small

JonathanBrouwer · 2025-07-08T06:25:06Z

@jdonszelmann I've squashed things down a bit. I'm experimenting a bit with what commit size is best for reviewability, this was clearly too much of a good thing :P

compiler/rustc_attr_parsing/src/attributes/proc_macro_attrs.rs

JonathanBrouwer · 2025-07-08T08:47:12Z

r? @jdonszelmann
@rustbot ready

rustbot · 2025-07-08T08:47:17Z

jdonszelmann is not on the review rotation at the moment.
They may take a while to respond.

bors · 2025-07-08T21:41:12Z

☔ The latest upstream changes (presumably #143645) made this pull request unmergeable. Please resolve the merge conflicts.

Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer · 2025-07-11T11:41:35Z

^ Rebased

jdonszelmann · 2025-07-11T15:17:54Z

Discussed with @oli-obk, we're going to do a crater run for this one because it's technically a breaking change.
First a try build, no need to rebase until crater's done which will take a bit :)

@bors try

Port the proc macro attributes to the new attribute parsing infrastructure Ports `#[proc_macro]`, `#[proc_macro_attribute]`, `#[proc_macro_derive]` and `#[rustc_builtin_macro]` to the new attribute parsing infrastructure for #131229 (comment) I've split this PR into commits for reviewability, and left some comments to clarify things I did 4 related attributes in one PR because they share a lot of their code and logic, and doing them separately is kind of annoying as I need to leave both the old and new parsing in place then. r? `@oli-obk` cc `@jdonszelmann`

bors · 2025-07-11T15:19:05Z

⌛ Trying commit f8c757f with merge 360f8e6...

jdonszelmann · 2025-07-11T15:23:58Z

@traviscross what's the proper way to notify T-lang on this? What label, and could you add that?

bors · 2025-07-11T17:36:10Z

☀️ Try build successful - checks-actions
Build commit: 360f8e6 (360f8e61048079e513337f716e2015067717b98e)

traviscross · 2025-07-11T20:08:08Z

@traviscross what's the proper way to notify T-lang on this? What label, and could you add that?

@rustbot labels +I-lang-nominated +T-lang
cc @rust-lang/lang

JonathanBrouwer · 2025-07-11T20:48:56Z

For reference for the lang team: #142838 (comment)

Could someone start crater? I don't think I have permission to do that

traviscross · 2025-07-11T21:00:38Z

@craterbot check

craterbot · 2025-07-11T21:01:06Z

👌 Experiment pr-143607 created and queued.
🤖 Automatically detected try build 360f8e6
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

rustbot assigned oli-obk Jul 7, 2025

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2025

JonathanBrouwer commented Jul 7, 2025

View reviewed changes

JonathanBrouwer marked this pull request as ready for review July 7, 2025 19:16

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2025

This comment has been minimized.

Sign in to view

JonathanBrouwer force-pushed the proc_macro_attrs branch from a6b7f55 to 432cde9 Compare July 8, 2025 06:24

jdonszelmann mentioned this pull request Jul 8, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

jdonszelmann reviewed Jul 8, 2025

View reviewed changes

compiler/rustc_attr_parsing/src/attributes/proc_macro_attrs.rs Show resolved Hide resolved

JonathanBrouwer force-pushed the proc_macro_attrs branch from 432cde9 to 7a60c84 Compare July 8, 2025 08:46

rustbot assigned jdonszelmann and unassigned oli-obk Jul 8, 2025

JonathanBrouwer force-pushed the proc_macro_attrs branch from 7a60c84 to a39cacf Compare July 9, 2025 08:21

JonathanBrouwer added 2 commits July 11, 2025 13:37

Add attributes to AttributeKind

6404cb0

Implement check_attr

40df0e8

JonathanBrouwer force-pushed the proc_macro_attrs branch from a39cacf to 2b42dae Compare July 11, 2025 11:40

JonathanBrouwer added 4 commits July 11, 2025 13:41

Parsers for the attributes

06eb5a5

Signed-off-by: Jonathan Brouwer <[email protected]>

Use the new attributes throughout the codebase

1a365ab

Signed-off-by: Jonathan Brouwer <[email protected]>

Update test results

4e3494b

Signed-off-by: Jonathan Brouwer <[email protected]>

Remove now un-used code

fab5ac2

Signed-off-by: Jonathan Brouwer <[email protected]>

Fix tooling

f8c757f

Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer force-pushed the proc_macro_attrs branch from 2b42dae to f8c757f Compare July 11, 2025 11:41

rustbot added the I-lang-nominated Nominated for discussion during a lang team meeting. label Jul 11, 2025

traviscross added P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang T-lang Relevant to the language team labels Jul 11, 2025

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2025

Port the proc macro attributes to the new attribute parsing infrastructure #143607

Are you sure you want to change the base?

Port the proc macro attributes to the new attribute parsing infrastructure #143607

Conversation

JonathanBrouwer commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jul 7, 2025

Uh oh!

This comment has been minimized.

rustbot commented Jul 7, 2025

Uh oh!

jdonszelmann commented Jul 7, 2025

Uh oh!

jdonszelmann commented Jul 7, 2025

Uh oh!

JonathanBrouwer commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JonathanBrouwer commented Jul 8, 2025

Uh oh!

rustbot commented Jul 8, 2025

Uh oh!

bors commented Jul 8, 2025

Uh oh!

JonathanBrouwer commented Jul 11, 2025

Uh oh!

jdonszelmann commented Jul 11, 2025

Uh oh!

bors commented Jul 11, 2025

Uh oh!

jdonszelmann commented Jul 11, 2025

Uh oh!

bors commented Jul 11, 2025

Uh oh!

traviscross commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

traviscross commented Jul 11, 2025

Uh oh!

craterbot commented Jul 11, 2025

Uh oh!

Uh oh!

JonathanBrouwer commented Jul 7, 2025 •

edited

Loading

JonathanBrouwer Jul 7, 2025 •

edited

Loading

JonathanBrouwer commented Jul 8, 2025 •

edited

Loading

traviscross commented Jul 11, 2025 •

edited

Loading

JonathanBrouwer commented Jul 11, 2025 •

edited

Loading