Port #[macro_export] to the new attribute parsing infrastructure #143857

Periodic1911 · 2025-07-12T22:00:14Z

Ports macro_export to the new attribute parsing infrastructure for #131229 (comment)

r? @oli-obk

cc @JonathanBrouwer @jdonszelmann

rustbot · 2025-07-12T22:00:20Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Periodic1911 · 2025-07-12T22:07:44Z

tests/ui/attributes/invalid_macro_export_argument.rs

@@ -26,12 +22,15 @@ macro_rules! d {
 }

 #[macro_export()]
+//~^ ERROR malformed `macro_export` attribute input


This is a breaking change! Malformed macro_export attributes have had a lint since 2023 (deny(invalid_macro_export_arguments)). This PR makes this an error.
Furthermore, #[macro_export()] has been accepted since 2023, and this PR makes that an error too.

As discussed in #142838 (comment), we can make breaking changes as long as we do a crater run. So this PR needs a crater run.

bors · 2025-07-13T05:32:15Z

☔ The latest upstream changes (presumably #140717) made this pull request unmergeable. Please resolve the merge conflicts.

jdonszelmann · 2025-07-13T08:02:56Z

@Periodic1911 if you rebase I'll run a crater

jdonszelmann · 2025-07-13T08:03:54Z

@rust-lang/lang this makes a long-standing warning an error with a crater run. Just wanted to notify you

jdonszelmann · 2025-07-13T12:54:46Z

@bors try

Port #[macro_export] to the new attribute parsing infrastructure Ports macro_export to the new attribute parsing infrastructure for #131229 (comment) r? `@oli-obk` cc `@JonathanBrouwer` `@jdonszelmann`

bors · 2025-07-13T12:55:57Z

⌛ Trying commit ac1f122 with merge 723ab94...

bors · 2025-07-13T15:12:39Z

☀️ Try build successful - checks-actions
Build commit: 723ab94 (723ab942d877517caf445dafde0416803ef56501)

jdonszelmann · 2025-07-13T15:34:00Z

@craterbot check

tmandry · 2025-07-16T15:34:42Z

We discussed this in the lang team triage meeting. We agreed on a plan to upgrade invalid_macro_export_arguments to FCW showing in dependencies, and also upgrade it to deny by default.

If and when we upgrade this lint to a hard error, we can add it to the removed_lints list and that should handle it correctly.

FCP to ratify this plan:

@rfcbot fcp merge

rfcbot · 2025-07-16T15:34:44Z

Team member @tmandry has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

traviscross · 2025-07-16T15:35:03Z

@rfcbot reviewed

rfcbot · 2025-07-16T15:37:35Z

🔔 This is now entering its final comment period, as per the review above. 🔔

Periodic1911 · 2025-07-16T17:17:31Z

Oh thanks scottmcm, I didn't know the dependencies tab showed results that aren't in the root results tab. Sorry, I'm new to this! 🙇‍♀️ And thank you for checking my work

rfcbot · 2025-07-26T15:43:30Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

jdonszelmann · 2025-07-27T14:37:53Z

@Periodic1911 FCP finished. if you rebase we can go for merge! :)

Periodic1911 · 2025-07-28T21:45:22Z

compiler/rustc_lint_defs/src/builtin.rs

@@ -4187,8 +4187,13 @@ declare_lint! {
    /// You can't have multiple arguments in a `#[macro_export(..)]`, or mention arguments other than `local_inner_macros`.
    ///
    pub INVALID_MACRO_EXPORT_ARGUMENTS,
-    Warn,
+    Deny,


This lint is now deny by default and FCW

Periodic1911 · 2025-07-28T21:52:15Z

@jdonszelmann rebased! And I made some changes to the parser error handling in accordance with the lang team's decision. Did I comply exactly with what they had in mind?

Periodic1911 · 2025-07-28T21:56:13Z

tests/ui/attributes/invalid_macro_export_argument.allow.stderr

@@ -0,0 +1,40 @@
+Future incompatibility report: Future breakage diagnostic:


Although the invalid_macro_export_argument.rs test passes (check-pass) with #![allow(invalid_macro_export_arguments)], it also prints FCWs to stderr

rust-log-analyzer · 2025-07-28T22:43:39Z

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   |             +                                                                     +

error: could not document `rustc_attr_data_structures`
warning: build failed, waiting for other jobs to finish...
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:38
  local time: Mon Jul 28 22:43:27 UTC 2025
  network time: Mon, 28 Jul 2025 22:43:27 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

rustbot assigned oli-obk Jul 12, 2025

Periodic1911 commented Jul 12, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Periodic1911 force-pushed the macro-export branch from 12474a6 to bb6c5dd Compare July 12, 2025 22:22

This comment has been minimized.

Sign in to view

jdonszelmann mentioned this pull request Jul 13, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

jdonszelmann added T-lang Relevant to the language team I-lang-nominated Nominated for discussion during a lang team meeting. labels Jul 13, 2025

Periodic1911 force-pushed the macro-export branch from bb6c5dd to 92071cc Compare July 13, 2025 10:27

rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jul 13, 2025

Periodic1911 force-pushed the macro-export branch from 92071cc to ac1f122 Compare July 13, 2025 10:33

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 16, 2025

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jul 16, 2025

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jul 16, 2025

oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2025

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jul 26, 2025

rfcbot added the to-announce Announce this issue on triage meeting label Jul 26, 2025

rustbot mentioned this pull request Jul 26, 2025

Tracking issue for release notes of #143857: Port #[macro_export] to the new attribute parsing infrastructure #144505

Open

oli-obk assigned jdonszelmann and unassigned oli-obk Jul 28, 2025

Port #[macro_export] to the new attribute parsing infrastructure

f9b9221

Periodic1911 force-pushed the macro-export branch from ac1f122 to f9b9221 Compare July 28, 2025 21:44

rustbot added T-clippy Relevant to the Clippy team. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jul 28, 2025

Periodic1911 commented Jul 28, 2025

View reviewed changes

		@@ -0,0 +1,40 @@
		Future incompatibility report: Future breakage diagnostic:

Port #[macro_export] to the new attribute parsing infrastructure #143857

Are you sure you want to change the base?

Port #[macro_export] to the new attribute parsing infrastructure #143857

Conversation

Periodic1911 commented Jul 12, 2025

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

Periodic1911 Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

tmandry commented Jul 16, 2025

Uh oh!

rfcbot commented Jul 16, 2025 • edited by joshtriplett Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

traviscross commented Jul 16, 2025

Uh oh!

rfcbot commented Jul 16, 2025

Uh oh!

Periodic1911 commented Jul 16, 2025

Uh oh!

rfcbot commented Jul 26, 2025

Uh oh!

jdonszelmann commented Jul 27, 2025

Uh oh!

Periodic1911 Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Periodic1911 commented Jul 28, 2025

Uh oh!

Periodic1911 Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-log-analyzer commented Jul 28, 2025

Uh oh!

Uh oh!

Periodic1911 Jul 12, 2025 •

edited

Loading

rfcbot commented Jul 16, 2025 •

edited by joshtriplett

Loading

Periodic1911 Jul 28, 2025 •

edited

Loading