Port #[macro_export] to the new attribute parsing infrastructure #143857

Periodic1911 · 2025-07-12T22:00:14Z

Ports macro_export to the new attribute parsing infrastructure for #131229 (comment)

r? @oli-obk

cc @JonathanBrouwer @jdonszelmann

rustbot · 2025-07-12T22:00:20Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Periodic1911 · 2025-07-12T22:07:44Z

tests/ui/attributes/invalid_macro_export_argument.rs

 }

 #[macro_export()]
+//~^ ERROR malformed `macro_export` attribute input


This is a breaking change! Malformed macro_export attributes have had a lint since 2023 (deny(invalid_macro_export_arguments)). This PR makes this an error.
Furthermore, #[macro_export()] has been accepted since 2023, and this PR makes that an error too.

As discussed in #142838 (comment), we can make breaking changes as long as we do a crater run. So this PR needs a crater run.

bors · 2025-07-13T05:32:15Z

☔ The latest upstream changes (presumably #140717) made this pull request unmergeable. Please resolve the merge conflicts.

jdonszelmann · 2025-07-13T08:02:56Z

@Periodic1911 if you rebase I'll run a crater

jdonszelmann · 2025-07-13T08:03:54Z

@rust-lang/lang this makes a long-standing warning an error with a crater run. Just wanted to notify you

jdonszelmann · 2025-07-13T12:54:46Z

@bors try

Port #[macro_export] to the new attribute parsing infrastructure Ports macro_export to the new attribute parsing infrastructure for #131229 (comment) r? `@oli-obk` cc `@JonathanBrouwer` `@jdonszelmann`

bors · 2025-07-13T12:55:57Z

⌛ Trying commit ac1f122 with merge 723ab94...

bors · 2025-07-13T15:12:39Z

☀️ Try build successful - checks-actions
Build commit: 723ab94 (723ab942d877517caf445dafde0416803ef56501)

jdonszelmann · 2025-07-13T15:34:00Z

@craterbot check

rustbot · 2025-08-16T10:16:07Z

This PR was rebased onto a different master commit! Check out the changes with our range-diff.

jdonszelmann · 2025-08-16T10:58:01Z

@rustbot review

Rollup of 19 pull requests Successful merges: - rust-lang/rust#137831 (Tweak auto trait errors) - rust-lang/rust#138689 (add nvptx_target_feature) - rust-lang/rust#140267 (implement continue_ok and break_ok for ControlFlow) - rust-lang/rust#143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - rust-lang/rust#143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - rust-lang/rust#143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - rust-lang/rust#143906 (Miri: non-deterministic floating point operations in `foreign_items`) - rust-lang/rust#143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - rust-lang/rust#144133 (Stabilize const TypeId::of) - rust-lang/rust#144369 (Upgrade semicolon_in_expressions_from_macros from warn to deny) - rust-lang/rust#144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - rust-lang/rust#144473 (Address libunwind.a inconsistency issues in the bootstrap program) - rust-lang/rust#144601 (Allow `cargo fix` to partially apply `mismatched_lifetime_syntaxes`) - rust-lang/rust#144650 (Additional tce tests) - rust-lang/rust#144659 (bootstrap: refactor mingw dist and fix gnullvm) - rust-lang/rust#144682 (Stabilize `strict_overflow_ops`) - rust-lang/rust#145026 (Update books) - rust-lang/rust#145033 (Reimplement `print_region` in `type_name.rs`.) - rust-lang/rust#145040 (rustc-dev-guide subtree update) Failed merges: - rust-lang/rust#143857 (Port #[macro_export] to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

jdonszelmann · 2025-09-14T05:39:35Z

@Periodic1911 the number of attribute PRs is quite low. If you rebased I would make sure this one is guaranteed to be merged ASAP without any going before it to conflict again.

jdonszelmann · 2025-09-19T18:10:19Z

@rustbot author

rustbot · 2025-09-19T18:10:24Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Co-authored-by: Anne Stijns <[email protected]>

rustbot · 2025-09-21T16:10:44Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2025-09-21T16:20:44Z

@rustbot ready

@jdonszelmann I rebased & did a little bit of cleanup for Anne as she didn't feel like doing it and it's nice to get this merged.

jdonszelmann · 2025-09-21T18:06:08Z

@bors r+ rollup

bors · 2025-09-21T18:06:12Z

📌 Commit f7fa83e has been approved by jdonszelmann

It is now in the queue for this repository.

…zelmann Port #[macro_export] to the new attribute parsing infrastructure Ports macro_export to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@oli-obk` cc `@JonathanBrouwer` `@jdonszelmann`

Rollup of 4 pull requests Successful merges: - #143857 (Port #[macro_export] to the new attribute parsing infrastructure) - #146486 (Improve `core::sync::atomic` coverage) - #146606 (ci: x86_64-gnu-tools: Add `--test-args` regression test) - #146639 (std: merge definitions of `StdioPipes`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #143857 - Periodic1911:macro-export, r=jdonszelmann Port #[macro_export] to the new attribute parsing infrastructure Ports macro_export to the new attribute parsing infrastructure for #131229 (comment) r? ``@oli-obk`` cc ``@JonathanBrouwer`` ``@jdonszelmann``

rustbot assigned oli-obk Jul 12, 2025

Periodic1911 commented Jul 12, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

Periodic1911 force-pushed the macro-export branch from 12474a6 to bb6c5dd Compare July 12, 2025 22:22

This comment has been minimized.

Sign in to view

jdonszelmann mentioned this pull request Jul 13, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

jdonszelmann added T-lang Relevant to the language team I-lang-nominated Nominated for discussion during a lang team meeting. labels Jul 13, 2025

Periodic1911 force-pushed the macro-export branch from bb6c5dd to 92071cc Compare July 13, 2025 10:27

rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jul 13, 2025

Periodic1911 force-pushed the macro-export branch from 92071cc to ac1f122 Compare July 13, 2025 10:33

apiraino removed the to-announce Announce this issue on triage meeting label Aug 14, 2025

Periodic1911 force-pushed the macro-export branch from 3091f58 to 5260e64 Compare August 16, 2025 10:16

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2025

JonathanBrouwer and others added 2 commits September 21, 2025 10:42

Port #[macro_export] to the new attribute parsing infrastructure

6abcadc

Co-authored-by: Anne Stijns <[email protected]>

Changes to uitests for macro_export port

f7fa83e

Co-authored-by: Anne Stijns <[email protected]>

JonathanBrouwer force-pushed the macro-export branch from 5260e64 to f7fa83e Compare September 21, 2025 16:10

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 21, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2025

This was referenced Sep 21, 2025

Rollup of 5 pull requests #146860

Closed

Rollup of 4 pull requests #146862

Merged

bors merged commit 7148a4f into rust-lang:master Sep 21, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Sep 21, 2025

Port #[macro_export] to the new attribute parsing infrastructure #143857

Port #[macro_export] to the new attribute parsing infrastructure #143857

Uh oh!

Conversation

Periodic1911 commented Jul 12, 2025

Uh oh!

rustbot commented Jul 12, 2025

Uh oh!

Periodic1911 Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

bors commented Jul 13, 2025

Uh oh!

jdonszelmann commented Jul 13, 2025

Uh oh!

rustbot commented Aug 16, 2025

Uh oh!

jdonszelmann commented Aug 16, 2025

Uh oh!

jdonszelmann commented Sep 14, 2025

Uh oh!

jdonszelmann commented Sep 19, 2025

Uh oh!

rustbot commented Sep 19, 2025

Uh oh!

rustbot commented Sep 21, 2025

Uh oh!

JonathanBrouwer commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Sep 21, 2025

Uh oh!

bors commented Sep 21, 2025

Uh oh!

Uh oh!

Uh oh!

Periodic1911 Jul 12, 2025 •

edited

Loading

JonathanBrouwer commented Sep 21, 2025 •

edited

Loading