Skip to content

Fix false positive double negations with macro invocation #144008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix false positive double negations with macro invocation #144008

wants to merge 1 commit into from
+38 −0

Conversation

anatawa12
Copy link
Contributor

@anatawa12 anatawa12 commented Jul 16, 2025 •
edited
Loading

This PR fixes false positive double_negations lint when macro expansion has negation and macro caller also has negations.

Fix #143980

@rustbot
Copy link
Collaborator

rustbot commented Jul 16, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 16, 2025
@compiler-errors
Copy link
Member

Can you please squash this into one commit? Then I can approve.

r? compiler-errors
@rustbot author

@rustbot rustbot assigned compiler-errors and unassigned davidtwco Jul 16, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 16, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@anatawa12 anatawa12 force-pushed the fix-double-negations branch from 08ea23b to fad8dec Compare July 17, 2025 02:25
@anatawa12
Copy link
Contributor Author

Yes. I've squashed to one commit.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2025
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 17, 2025

📌 Commit fad8dec has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

false positive double_negations warning with macro invocation
5 participants
@anatawa12 @rustbot @compiler-errors @bors @davidtwco