Skip to content

Miri subtree update #144019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Jul 17, 2025
Merged

Miri subtree update #144019

merged 44 commits into from
Jul 17, 2025

Conversation

RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 30 commits July 5, 2025 10:32
@RalfJung
miri-script: set msrv so clippy doesn't suggest too-new features
4350659
@RalfJung
Merge pull request rust-lang#4447 from RalfJung/miri-script-msrv
6ea0b65 
miri-script: set msrv so clippy doesn't suggest too-new features
@devnexen
shims::fs adding more fields to FileMetadata
d87984e 
addressing, partially at least, FIXME comment and
targetting unixes, adding device, user and group ids.
@RalfJung
minor cleanup
ef0490c
@RalfJung
Merge pull request rust-lang#4444 from devnexen/filemetadata_upd
b2d8c81 
shims::fs adding more fields to FileMetadata
@RalfJung
rename panic_paylods → unwind_payloads
e40f8b2
Preparing for merge from rustc
59af8f3
Merge from rustc
0e043a8
@RalfJung
Merge pull request rust-lang#4449 from rust-lang/rustup-2025-07-07
51cba78 
Automatic Rustup
@RalfJung
split unwinding logic from panic logic
ae3b976
@RalfJung
Merge pull request rust-lang#4450 from RalfJung/unwind-payloads
a96e73f 
Unwinding != panicking
@RalfJung
move our data structures into a central location
e296e6b
@RalfJung
Preparing for merge from rustc
0d306dd
@RalfJung
Merge from rustc
bd84ba8
@RalfJung
Merge pull request rust-lang#4455 from RalfJung/rustup
9110617 
Rustup
@oli-obk
Merge pull request rust-lang#4454 from RalfJung/data_structure
5058f90 
move our data structures into a central location
@nia-e @RalfJung
various native-lib-trace-related fixups
3bd0b89 
Co-Authored-By: Ralf Jung <[email protected]>
@RalfJung
Merge pull request rust-lang#4435 from nia-e/trace-fixups
a09cf9c 
native_lib/trace: fix and reenable
Preparing for merge from rustc
e726c64
Merge from rustc
1f721c6
fmt
5e940f5
@RalfJung
silence clippy
17b240e
@RalfJung
Merge pull request rust-lang#4458 from rust-lang/rustup-2025-07-10
317f59d 
Automatic Rustup
@RalfJung
readme: update strict provenance link
bccc32b
@RalfJung
Merge pull request rust-lang#4465 from RalfJung/readme-strict-provenance
91a52ca 
readme: update strict provenance link
Preparing for merge from rustc
dbeb05c
Merge from rustc
8812d74
@RalfJung
Merge pull request rust-lang#4467 from rust-lang/rustup-2025-07-14
794dc32 
Automatic Rustup
Preparing for merge from rustc
a9a5b33
Merge from rustc
f7da021
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 16, 2025

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

📌 Commit fe090db has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025
@RalfJung
Copy link
Member Author

@bors p=1

bors added a commit that referenced this pull request Jul 16, 2025
@bors
Auto merge of #144019 - RalfJung:miri-sync, r=RalfJung
54eff6c 
Miri subtree update

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Jul 16, 2025

⌛ Testing commit fe090db with merge 54eff6c...

bors added a commit that referenced this pull request Jul 16, 2025
@bors
Auto merge of #144019 - RalfJung:miri-sync, r=RalfJung
d5c76b8 
Miri subtree update

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Jul 16, 2025

⌛ Testing commit fe090db with merge d5c76b8...

@matthiaskrgr
Copy link
Member

🤔

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

⌛ Testing commit fe090db with merge fd2eb39...

@bors
Copy link
Collaborator

bors commented Jul 17, 2025

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing fd2eb39 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 17, 2025
@bors bors merged commit fd2eb39 into rust-lang:master Jul 17, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5795086 (parent) -> fd2eb39 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fd2eb391d032181459773f3498c17b198513e0d0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 65.1s -> 127.7s (96.2%)
  2. aarch64-apple: 3830.4s -> 5224.9s (36.4%)
  3. dist-aarch64-linux: 8654.3s -> 6046.1s (-30.1%)
  4. x86_64-apple-2: 3463.2s -> 4059.0s (17.2%)
  5. dist-aarch64-apple: 7085.0s -> 6254.3s (-11.7%)
  6. x86_64-gnu-tools: 3673.2s -> 3313.2s (-9.8%)
  7. dist-loongarch64-linux: 6447.2s -> 5898.7s (-8.5%)
  8. x86_64-gnu-aux: 6657.0s -> 6141.6s (-7.7%)
  9. x86_64-gnu-llvm-19-2: 5912.6s -> 5456.4s (-7.7%)
  10. x86_64-apple-1: 7005.9s -> 7540.6s (7.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bors bors mentioned this pull request Jul 17, 2025
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fd2eb39): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.2%, 0.5%] 12
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.5% [3.5%, 3.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.9% [-1.9%, -1.9%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 466.738s -> 467.109s (0.08%)
Artifact size: 374.76 MiB -> 374.84 MiB (0.02%)

@rustbot rustbot added the perf-regression Performance regression. label Jul 17, 2025
@Kobzol
Copy link
Member

Kobzol commented Jul 17, 2025

Maybe some tiny regression in CTFE?

@lqd
Copy link
Member

lqd commented Jul 17, 2025

how?

@Kobzol
Copy link
Member

Kobzol commented Jul 17, 2025

Oh, I thought that CTFE actually uses code from miri, but it's probably the other way around? In that case nevermind.

@RalfJung
Copy link
Member Author

RalfJung commented Jul 17, 2025 •
edited
Loading

This PR does not change anything in compiler/ or its dependencies, so all perf effects must be spurious.

@Kobzol
Copy link
Member

Kobzol commented Jul 17, 2025

Fair enough.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 17, 2025
@RalfJung RalfJung deleted the miri-sync branch July 17, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.