Use tcx.short_string() in more diagnostics
#144039
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
estebank
commented
Jul 16, 2025
Comment on lines
1
to
3
| // FIXME(estebank): diagnostics with long type paths that don't print out the full path anywhere | ||
| // still prints the note explaining where the type was written to. | ||
| //@ compile-flags: -Zwrite-long-types-to-disk=yes |
There was a problem hiding this comment.
I found these by changing the default -Zwrite-long-types-to-disk=no in compiletest::runtest::TestCx::make_compile_args to yes, which highlighted some preexisting cases that I'll investigate.
There was a problem hiding this comment.
One left: tests/ui/methods/filter-relevant-fn-bounds.rs. Also pre-existing.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
`TyCtxt::short_string` ensures that user visible type paths aren't overwhelming on the terminal output, and properly saves the long name to disk as a side-channel. We already use these throughout the compiler and have been using them as needed when users find cases where the output is verbose. This is a proactive search of some cases to use `short_string`. We add support for shortening the path of "trait path only". Every manual use of `short_string` is a bright marker that that error should be using structured diagnostics instead (as they have proper handling of long types without the maintainer having to think abou tthem).
When we don't actually print out a shortened type we don't need the "use `--verbose`" note.
This test seems to have improper use of `TyCtxt::short_string`.
estebank
commented
Jul 18, 2025
Comment on lines
+578
to
+602
| // Don't show generic arguments when the method can't be found in any implementation (#81576). | ||
| let mut ty_str = None; | ||
| if let ty::Adt(_, generics) = ty.kind() { | ||
| if generics.len() > 0 { | ||
| let mut autoderef = self.autoderef(DUMMY_SP, ty).silence_errors(); | ||
| let candidate_found = autoderef.any(|(ty, _)| { | ||
| if let ty::Adt(adt_def, _) = ty.kind() { | ||
| self.tcx.inherent_impls(adt_def.did()).into_iter().any( | ||
| |def_id| { | ||
| self.associated_value(*def_id, method_name).is_some() | ||
| }, | ||
| ) | ||
| } else { | ||
| false | ||
| } | ||
| }); | ||
| let has_deref = autoderef.step_count() > 0; | ||
| if !candidate_found && !has_deref && unsatisfied_predicates.is_empty() { | ||
| let t = with_forced_trimmed_paths!(ty.to_string()); | ||
| if let Some((path_string, _)) = t.split_once('<') { | ||
| ty_str = Some(path_string.to_string()); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is moved code from 656.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TyCtxt::short_stringensures that user visible type paths aren't overwhelming on the terminal output, and properly saves the long name to disk as a side-channel. We already use these throughout the compiler and have been using them as needed when users find cases where the output is verbose. This is a proactive search of some cases to useshort_string.We add support for shortening the path of "trait path only".
Every manual use of
short_stringis a bright marker that that error should be using structured diagnostics instead (as they have proper handling of long types without the maintainer having to think abou tthem).